From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: WangYuli <wangyuli@uniontech.com>,
mark.rutland@arm.com, tsbogend@alpha.franken.de,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, xzhong86@163.com,
wuzhangjin@gmail.com, srostedt@redhat.com,
linux-mips@linux-mips.org, ralf@duck.linux-mips.net,
jeffbai@aosc.io, zhanjun@uniontech.com, guanwentao@uniontech.com,
jiaxun.yang@flygoat.com, gregory.clement@bootlin.com,
philmd@linaro.org, tglx@linutronix.de, rppt@kernel.org
Subject: Re: [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static
Date: Mon, 6 Jan 2025 15:22:40 -0500 [thread overview]
Message-ID: <20250106152240.7e2220bc@gandalf.local.home> (raw)
In-Reply-To: <20250105173747.3859102eeabed7ffba8cbc07@kernel.org>
On Sun, 5 Jan 2025 17:37:47 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> On Sat, 4 Jan 2025 22:47:08 +0800
> WangYuli <wangyuli@uniontech.com> wrote:
>
> > Declare ftrace_get_parent_ra_addr() as static to suppress clang
> > compiler warning that 'no previous prototype'. This function is
> > not intended to be called from other parts.
> >
> > Fix follow error with clang-19:
> >
> > arch/mips/kernel/ftrace.c:251:15: error: no previous prototype for function 'ftrace_get_parent_ra_addr' [-Werror,-Wmissing-prototypes]
> > 251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
> > | ^
> > arch/mips/kernel/ftrace.c:251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > 251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
> > | ^
> > | static
> > 1 error generated.
>
> Looks good to me.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
Note, this should go through the MIPS tree.
-- Steve
next prev parent reply other threads:[~2025-01-06 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 14:47 [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static WangYuli
2025-01-05 8:37 ` Masami Hiramatsu
2025-01-06 20:22 ` Steven Rostedt [this message]
2025-01-10 8:13 ` Philippe Mathieu-Daudé
2025-01-11 12:02 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106152240.7e2220bc@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=gregory.clement@bootlin.com \
--cc=guanwentao@uniontech.com \
--cc=jeffbai@aosc.io \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=philmd@linaro.org \
--cc=ralf@duck.linux-mips.net \
--cc=rppt@kernel.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=wangyuli@uniontech.com \
--cc=wuzhangjin@gmail.com \
--cc=xzhong86@163.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox