public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: WangYuli <wangyuli@uniontech.com>
To: rostedt@goodmis.org, mhiramat@kernel.org, mark.rutland@arm.com,
	tsbogend@alpha.franken.de
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org, xzhong86@163.com,
	wuzhangjin@gmail.com, srostedt@redhat.com,
	linux-mips@linux-mips.org, ralf@duck.linux-mips.net,
	jeffbai@aosc.io, zhanjun@uniontech.com, guanwentao@uniontech.com,
	jiaxun.yang@flygoat.com, gregory.clement@bootlin.com,
	philmd@linaro.org, tglx@linutronix.de, rppt@kernel.org,
	WangYuli <wangyuli@uniontech.com>
Subject: [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static
Date: Sat,  4 Jan 2025 22:47:08 +0800	[thread overview]
Message-ID: <527F9AFF0430AB45+20250104144708.18438-1-wangyuli@uniontech.com> (raw)

Declare ftrace_get_parent_ra_addr() as static to suppress clang
compiler warning that 'no previous prototype'. This function is
not intended to be called from other parts.

Fix follow error with clang-19:

arch/mips/kernel/ftrace.c:251:15: error: no previous prototype for function 'ftrace_get_parent_ra_addr' [-Werror,-Wmissing-prototypes]
  251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
      |               ^
arch/mips/kernel/ftrace.c:251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
  251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
      | ^
      | static
1 error generated.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/kernel/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
index 8c401e42301c..f39e85fd58fa 100644
--- a/arch/mips/kernel/ftrace.c
+++ b/arch/mips/kernel/ftrace.c
@@ -248,7 +248,7 @@ int ftrace_disable_ftrace_graph_caller(void)
 #define S_R_SP	(0xafb0 << 16)	/* s{d,w} R, offset(sp) */
 #define OFFSET_MASK	0xffff	/* stack offset range: 0 ~ PT_SIZE */
 
-unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
+static unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
 		old_parent_ra, unsigned long parent_ra_addr, unsigned long fp)
 {
 	unsigned long sp, ip, tmp;
-- 
2.45.2


             reply	other threads:[~2025-01-04 14:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-04 14:47 WangYuli [this message]
2025-01-05  8:37 ` [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static Masami Hiramatsu
2025-01-06 20:22   ` Steven Rostedt
2025-01-10  8:13 ` Philippe Mathieu-Daudé
2025-01-11 12:02 ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527F9AFF0430AB45+20250104144708.18438-1-wangyuli@uniontech.com \
    --to=wangyuli@uniontech.com \
    --cc=gregory.clement@bootlin.com \
    --cc=guanwentao@uniontech.com \
    --cc=jeffbai@aosc.io \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=philmd@linaro.org \
    --cc=ralf@duck.linux-mips.net \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    --cc=wuzhangjin@gmail.com \
    --cc=xzhong86@163.com \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox