Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Tomas Glozar <tglozar@redhat.com>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	John Kacur <jkacur@redhat.com>,
	Luis Goncalves <lgoncalv@redhat.com>, Chang Yin <cyin@redhat.com>,
	Qiao Zhao <qzhao@redhat.com>
Subject: Re: [PATCH] tools/rtla: Add basic test suite
Date: Thu, 16 Jan 2025 20:18:08 -0500	[thread overview]
Message-ID: <20250116201808.3c8721c1@gandalf.local.home> (raw)
In-Reply-To: <20250109133852.360122-1-tglozar@redhat.com>

On Thu,  9 Jan 2025 14:38:52 +0100
Tomas Glozar <tglozar@redhat.com> wrote:

> Implement a simple TAP-based test engine in bash and a few basic tests
> using it, to be used to check for bugs and regressions.
> 
> A new "check" target is added to the rtla Makefile that runs the test suite
> using the "prove" command implemented by Test::Harness.
> 
> The only test format currently supported is running rtla with defined
> command arguments per test, checking its exit code. In case the exit
> code is non-zero, the output of rtla is displayed.
> 
> The test cases are adopted from rtla tests in the Continuous Kernel
> Integration (CKI) project [1] with the authors' approval.
> 
> [1] https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests/-/blob/main/rt-tests/us/rtla/
> 
> Signed-off-by: Tomas Glozar <tglozar@redhat.com>

I tested this out, and it failed the last test:

make[1]: Leaving directory '/work/git/linux.git/tools/tracing/rtla'
RTLA=/work/git/linux.git/tools/tracing/rtla/rtla prove -o -f tests/
tests/hwnoise.t ... ok      
tests/osnoise.t ... ok   
tests/timerlat.t .. 9/9 
not ok 9 - hist test in nanoseconds
# 
tests/timerlat.t .. Failed 1/9 subtests 

Test Summary Report
-------------------
tests/timerlat.t (Wstat: 0 Tests: 9 Failed: 1)
  Failed test:  9
Files=3, Tests=20, 451 wallclock secs ( 0.07 usr  0.11 sys + 10.57 cusr 74.09 csys = 84.84 CPU)
Result: FAIL
make: *** [Makefile:89: check] Error 1

-- Steve

  reply	other threads:[~2025-01-17  1:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 13:38 [PATCH] tools/rtla: Add basic test suite Tomas Glozar
2025-01-17  1:18 ` Steven Rostedt [this message]
2025-01-17 10:53   ` Tomas Glozar
2025-01-17 10:59     ` Steven Rostedt
2025-01-17 21:02     ` Steven Rostedt
2025-01-20  7:38       ` Tomas Glozar
2025-01-20 12:14         ` Tomas Glozar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250116201808.3c8721c1@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=cyin@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=qzhao@redhat.com \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox