Re: [PATCH] tools/rtla: Add basic test suite

[Steven Rostedt <rostedt@goodmis.org>]

On Fri, 17 Jan 2025 11:53:48 +0100
Tomas Glozar <tglozar@redhat.com> wrote:

> Maybe after enough time repeating the command I'm also going to hit
> the bug you saw.

Nevermind. The divide by zero fix went into my tools/urgent branch and I
pushed it up to Linus, but I had already started the tools/core branch for
the next merge window that I've been adding these patches to. It does not
include the fix.

The reason for that crash was because of the divide by zero bug. After
cherry-picking it for testing, it works.

Now, what I also noticed was. When it did crash and die. The osnoise tracer
no longer creates any osnoise threads. Can you take a look.

Remove the fix, and run that test:

 ~# echo osnoise > /sys/kernel/tracing/current_tracer
 ~# ps aux |grep osnois
root         942  105  0.0      0     0 ?        R    16:00   0:02 [osnoise/0]
root         943  104  0.0      0     0 ?        R    16:00   0:02 [osnoise/1]
root         944  105  0.0      0     0 ?        R    16:00   0:02 [osnoise/2]
root         945  105  0.0      0     0 ?        R    16:00   0:02 [osnoise/3]
root         946  105  0.0      0     0 ?        R    16:00   0:02 [osnoise/4]
root         947  105  0.0      0     0 ?        R    16:00   0:02 [osnoise/5]
root         948  104  0.0      0     0 ?        R    16:00   0:02 [osnoise/6]
root         949  130  0.0      0     0 ?        R    16:00   0:03 [osnoise/7]
root         953  9.0  0.0   6468  2152 pts/0    S+   16:00   0:00 grep osnois

 ~# echo nop > /sys/kernel/tracing/current_tracer
 ~# cd linux.git
 ~# git show cfff4d019b4c01 | patch -p1 -R
 ~# cd tools/tracing/rtla/
 ~# make
 ~# ./rtla timerlat hist -i 2 -c 0 -n -d 30s
 # RTLA timerlat histogram
 # Time unit is nanoseconds (ns)
 # Duration:   0 00:00:02
 Index   IRQ-000   Thr-000   Usr-000
 over:         1         0         0 
 count:        1         0         0 
 min:    1481365         -         - 
 avg:    1481365         -         - 
 max:    1481365         -         - 
 Floating point exception

 ~# rmdir /sys/kernel/tracing/instances/timerlat_aa/
 ~# rmdir /sys/kernel/tracing/instances/timerlat_hist/

 ~# echo osnoise > /sys/kernel/tracing/current_tracer
 ~# ps aux |grep osnois
root         969 11.1  0.0   6468  2244 pts/0    S+   15:54   0:00 grep osnois

So that failure puts the system into a state that can no longer run osnoise.
It takes a reboot to fix it.

That should be fixed where a reboot is not needed.

-- Steve