From: Steven Rostedt <rostedt@goodmis.org>
To: Kassey Li <quic_yingangl@quicinc.com>
Cc: <mhiramat@kernel.org>, <mathieu.desnoyers@efficios.com>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: trace: change the rtn log in hex format
Date: Wed, 7 May 2025 11:54:46 -0400 [thread overview]
Message-ID: <20250507115446.55e09c7f@gandalf.local.home> (raw)
In-Reply-To: <20250507070714.2387602-1-quic_yingangl@quicinc.com>
On Wed, 7 May 2025 15:07:14 +0800
Kassey Li <quic_yingangl@quicinc.com> wrote:
This patch is fine with me, but it needs to go through the scsi maintainers.
I don't see them Cc'd.
-- Steve
> In default it showed rtn in decimal.
>
> kworker/3:1H-183 [003] .... 51.035474: scsi_dispatch_cmd_error: host_no=0 channel=0 id=0 lun=4 data_sgl=1 prot_sgl=0 prot_op=SCSI_PROT_NORMAL cmnd=(READ_10 lba=3907214 txlen=1 protect=0 raw=28 00 00 3b 9e 8e 00 00 01 00) rtn=4181
>
> In source code we define these possible value as hexadecimal:
>
> include/scsi/scsi.h
>
> SCSI_MLQUEUE_HOST_BUSY 0x1055
> SCSI_MLQUEUE_DEVICE_BUSY 0x1056
> SCSI_MLQUEUE_EH_RETRY 0x1057
> SCSI_MLQUEUE_TARGET_BUSY 0x1058
>
> This change converts the rtn in hexadecimal.
>
> Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
> ---
> include/trace/events/scsi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/scsi.h b/include/trace/events/scsi.h
> index bf6cc98d9122..a4c089ac834c 100644
> --- a/include/trace/events/scsi.h
> +++ b/include/trace/events/scsi.h
> @@ -240,7 +240,7 @@ TRACE_EVENT(scsi_dispatch_cmd_error,
>
> TP_printk("host_no=%u channel=%u id=%u lun=%u data_sgl=%u prot_sgl=%u" \
> " prot_op=%s driver_tag=%d scheduler_tag=%d cmnd=(%s %s raw=%s)" \
> - " rtn=%d",
> + " rtn=0x%x",
> __entry->host_no, __entry->channel, __entry->id,
> __entry->lun, __entry->data_sglen, __entry->prot_sglen,
> show_prot_op_name(__entry->prot_op), __entry->driver_tag,
next prev parent reply other threads:[~2025-05-07 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 7:07 [PATCH] scsi: trace: change the rtn log in hex format Kassey Li
2025-05-07 15:54 ` Steven Rostedt [this message]
2025-05-08 1:21 ` Kassey Li quic
-- strict thread matches above, loose matches on Subject: below --
2025-05-09 5:38 Kassey Li
2025-05-12 16:11 ` Steven Rostedt
2025-05-14 7:43 ` Kassey Li quic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507115446.55e09c7f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=quic_yingangl@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox