Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: maz@kernel.org, linux-trace-kernel@vger.kernel.org,
	kvmarm@lists.linux.dev, kernel-team@android.com,
	Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] tracing: Update undefined symbols allow list for simple_ring_buffer
Date: Thu, 12 Mar 2026 09:33:11 -0400	[thread overview]
Message-ID: <20260312093311.1788707d@gandalf.local.home> (raw)
In-Reply-To: <20260312113535.2213350-1-vdonnefort@google.com>

On Thu, 12 Mar 2026 11:35:35 +0000
Vincent Donnefort <vdonnefort@google.com> wrote:

> Undefined symbols are not allowed for simple_ring_buffer.c. But some
> compiler emitted symbols are missing in the allowlist. Update it.
> 

Should add:

Fixes: a717943d8ecc ("tracing: Check for undefined symbols in simple_ring_buffer")
Closes: https://lore.kernel.org/all/20260311221816.GA316631@ax162/

> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>

Should this go through the arm tree or mine?

I'm fine with either, and in case the arm tree:

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve


> 
> diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
> index 3182e1bc1cf7..3cc490aadc99 100644
> --- a/kernel/trace/Makefile
> +++ b/kernel/trace/Makefile
> @@ -137,7 +137,8 @@ obj-$(CONFIG_TRACE_REMOTE_TEST) += remote_test.o
>  # to all kernel symbols. Fail the build if forbidden symbols are found.
>  #
>  UNDEFINED_ALLOWLIST := memset alt_cb_patch_nops __x86 __ubsan __asan __kasan __gcov __aeabi_unwind
> -UNDEFINED_ALLOWLIST += __stack_chk_fail stackleak_track_stack __ref_stack __sanitizer
> +UNDEFINED_ALLOWLIST += __stack_chk_fail stackleak_track_stack __ref_stack __sanitizer llvm_gcda llvm_gcov
> +UNDEFINED_ALLOWLIST += .TOC\. __clear_pages_unrolled __memmove copy_page warn_slowpath_fmt
>  UNDEFINED_ALLOWLIST := $(addprefix -e , $(UNDEFINED_ALLOWLIST))
>  
>  quiet_cmd_check_undefined = NM      $<
> 
> base-commit: 455baa581922086f1ad44c76d4a3b03c265ee950


  reply	other threads:[~2026-03-12 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 11:35 [PATCH] tracing: Update undefined symbols allow list for simple_ring_buffer Vincent Donnefort
2026-03-12 13:33 ` Steven Rostedt [this message]
2026-03-12 15:44 ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312093311.1788707d@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=nathan@kernel.org \
    --cc=vdonnefort@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox