Linux Trace Kernel
 help / color / mirror / Atom feed
* [PATCH] tracing: Update undefined symbols allow list for simple_ring_buffer
@ 2026-03-12 11:35 Vincent Donnefort
  2026-03-12 13:33 ` Steven Rostedt
  2026-03-12 15:44 ` Marc Zyngier
  0 siblings, 2 replies; 3+ messages in thread
From: Vincent Donnefort @ 2026-03-12 11:35 UTC (permalink / raw)
  To: maz
  Cc: rostedt, linux-trace-kernel, kvmarm, kernel-team,
	Vincent Donnefort, Nathan Chancellor

Undefined symbols are not allowed for simple_ring_buffer.c. But some
compiler emitted symbols are missing in the allowlist. Update it.

Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Vincent Donnefort <vdonnefort@google.com>

diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
index 3182e1bc1cf7..3cc490aadc99 100644
--- a/kernel/trace/Makefile
+++ b/kernel/trace/Makefile
@@ -137,7 +137,8 @@ obj-$(CONFIG_TRACE_REMOTE_TEST) += remote_test.o
 # to all kernel symbols. Fail the build if forbidden symbols are found.
 #
 UNDEFINED_ALLOWLIST := memset alt_cb_patch_nops __x86 __ubsan __asan __kasan __gcov __aeabi_unwind
-UNDEFINED_ALLOWLIST += __stack_chk_fail stackleak_track_stack __ref_stack __sanitizer
+UNDEFINED_ALLOWLIST += __stack_chk_fail stackleak_track_stack __ref_stack __sanitizer llvm_gcda llvm_gcov
+UNDEFINED_ALLOWLIST += .TOC\. __clear_pages_unrolled __memmove copy_page warn_slowpath_fmt
 UNDEFINED_ALLOWLIST := $(addprefix -e , $(UNDEFINED_ALLOWLIST))
 
 quiet_cmd_check_undefined = NM      $<

base-commit: 455baa581922086f1ad44c76d4a3b03c265ee950
-- 
2.53.0.851.ga537e3e6e9-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tracing: Update undefined symbols allow list for simple_ring_buffer
  2026-03-12 11:35 [PATCH] tracing: Update undefined symbols allow list for simple_ring_buffer Vincent Donnefort
@ 2026-03-12 13:33 ` Steven Rostedt
  2026-03-12 15:44 ` Marc Zyngier
  1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2026-03-12 13:33 UTC (permalink / raw)
  To: Vincent Donnefort
  Cc: maz, linux-trace-kernel, kvmarm, kernel-team, Nathan Chancellor

On Thu, 12 Mar 2026 11:35:35 +0000
Vincent Donnefort <vdonnefort@google.com> wrote:

> Undefined symbols are not allowed for simple_ring_buffer.c. But some
> compiler emitted symbols are missing in the allowlist. Update it.
> 

Should add:

Fixes: a717943d8ecc ("tracing: Check for undefined symbols in simple_ring_buffer")
Closes: https://lore.kernel.org/all/20260311221816.GA316631@ax162/

> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>

Should this go through the arm tree or mine?

I'm fine with either, and in case the arm tree:

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve


> 
> diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
> index 3182e1bc1cf7..3cc490aadc99 100644
> --- a/kernel/trace/Makefile
> +++ b/kernel/trace/Makefile
> @@ -137,7 +137,8 @@ obj-$(CONFIG_TRACE_REMOTE_TEST) += remote_test.o
>  # to all kernel symbols. Fail the build if forbidden symbols are found.
>  #
>  UNDEFINED_ALLOWLIST := memset alt_cb_patch_nops __x86 __ubsan __asan __kasan __gcov __aeabi_unwind
> -UNDEFINED_ALLOWLIST += __stack_chk_fail stackleak_track_stack __ref_stack __sanitizer
> +UNDEFINED_ALLOWLIST += __stack_chk_fail stackleak_track_stack __ref_stack __sanitizer llvm_gcda llvm_gcov
> +UNDEFINED_ALLOWLIST += .TOC\. __clear_pages_unrolled __memmove copy_page warn_slowpath_fmt
>  UNDEFINED_ALLOWLIST := $(addprefix -e , $(UNDEFINED_ALLOWLIST))
>  
>  quiet_cmd_check_undefined = NM      $<
> 
> base-commit: 455baa581922086f1ad44c76d4a3b03c265ee950


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tracing: Update undefined symbols allow list for simple_ring_buffer
  2026-03-12 11:35 [PATCH] tracing: Update undefined symbols allow list for simple_ring_buffer Vincent Donnefort
  2026-03-12 13:33 ` Steven Rostedt
@ 2026-03-12 15:44 ` Marc Zyngier
  1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2026-03-12 15:44 UTC (permalink / raw)
  To: Vincent Donnefort
  Cc: rostedt, linux-trace-kernel, kvmarm, kernel-team,
	Nathan Chancellor

On Thu, 12 Mar 2026 11:35:35 +0000, Vincent Donnefort wrote:
> Undefined symbols are not allowed for simple_ring_buffer.c. But some
> compiler emitted symbols are missing in the allowlist. Update it.
> 
> 

Applied to next, thanks!

[1/1] tracing: Update undefined symbols allow list for simple_ring_buffer
      commit: 5f2f83047126f1cb2986d142d2e76e1fa3cef3f0

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-12 15:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-12 11:35 [PATCH] tracing: Update undefined symbols allow list for simple_ring_buffer Vincent Donnefort
2026-03-12 13:33 ` Steven Rostedt
2026-03-12 15:44 ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox