From: chenqiwu <qiwuchen55@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "qiwu.chen" <qiwuchen55@gmail.com>,
akpm@linux-foundation.org, rostedt@goodmis.org,
kasong@tencent.com, mhocko@kernel.org, hannes@cmpxchg.org,
david@kernel.org, ljs@kernel.org, baohua@kernel.org,
mhiramat@kernel.org, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: rework lru_shrink and write_folio tracepoints
Date: Sun, 3 May 2026 22:52:05 +0800 [thread overview]
Message-ID: <20260503145205.GA3181@rlk> (raw)
In-Reply-To: <afdBCWopkfF2ow-Z@casper.infradead.org>
On Sun, May 03, 2026 at 01:35:21PM +0100, Matthew Wilcox wrote:
>
> You also removed the printing of the folio's PFN. Was this deliberate?
> If so, it merits a mention in the commit description.
>
> Also if you are going to do this (and I suspect we should do this!)
> we don't need to do the folio -> pfn -> page conversion. We can just
> store the folio pointer and print out the folio pointer.
>
Yes, I think printing out the PFN is indeed unnecessary, but miss to
merit a mention in commit messsage. I will remove the unnecessary
conversion and merit a mention in patch v2.
prev parent reply other threads:[~2026-05-03 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 8:57 [PATCH] mm: vmscan: rework lru_shrink and write_folio tracepoints qiwu.chen
2026-05-03 12:35 ` Matthew Wilcox
2026-05-03 14:52 ` chenqiwu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260503145205.GA3181@rlk \
--to=qiwuchen55@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mhocko@kernel.org \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox