From: Matthew Wilcox <willy@infradead.org>
To: "qiwu.chen" <qiwuchen55@gmail.com>
Cc: akpm@linux-foundation.org, rostedt@goodmis.org,
kasong@tencent.com, mhocko@kernel.org, hannes@cmpxchg.org,
david@kernel.org, ljs@kernel.org, baohua@kernel.org,
mhiramat@kernel.org, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org,
"qiwu.chen" <qiwu.chen@transsion.com>
Subject: Re: [PATCH] mm: vmscan: rework lru_shrink and write_folio tracepoints
Date: Sun, 3 May 2026 13:35:21 +0100 [thread overview]
Message-ID: <afdBCWopkfF2ow-Z@casper.infradead.org> (raw)
In-Reply-To: <20260503085705.3276-1-qiwu.chen@transsion.com>
On Sun, May 03, 2026 at 04:57:05PM +0800, qiwu.chen wrote:
> Currently, reclaim_flags always contains RECLAIM_WB_ASYNC in lru_shrink
> tracepoints since commit 41ac1999c3e35 ("mm: vmscan: do not stall on
> writeback during memory compaction"), which is useless for debugging
> memory pressure issues. Other RECLAIM_WB_* flags are not used anywhere
> else, so they can be directly removed.
> This patch reworks the lru_shrink and write_folio tracepoints for better
> correlation and analysis:
> - traces each folio lru type instead of reclaim_flags.
> - traces each lru_shrink with reason.
You also removed the printing of the folio's PFN. Was this deliberate?
If so, it merits a mention in the commit description.
Also if you are going to do this (and I suspect we should do this!)
we don't need to do the folio -> pfn -> page conversion. We can just
store the folio pointer and print out the folio pointer.
next prev parent reply other threads:[~2026-05-03 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 8:57 [PATCH] mm: vmscan: rework lru_shrink and write_folio tracepoints qiwu.chen
2026-05-03 12:35 ` Matthew Wilcox [this message]
2026-05-03 14:52 ` chenqiwu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afdBCWopkfF2ow-Z@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mhocko@kernel.org \
--cc=qiwu.chen@transsion.com \
--cc=qiwuchen55@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox