Linux Trace Kernel
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Gabriele Monaco <gmonaco@redhat.com>,
	linux-trace-kernel@vger.kernel.org
Cc: Wen Yang <wen.yang@linux.dev>, Nam Cao <namcao@linutronix.de>
Subject: [PATCH v4 09/13] rv: Prevent task migration while handling per-CPU events
Date: Mon,  1 Jun 2026 17:38:36 +0200	[thread overview]
Message-ID: <20260601153840.124372-10-gmonaco@redhat.com> (raw)
In-Reply-To: <20260601153840.124372-1-gmonaco@redhat.com>

Tracepoint handlers are fully preemptible after a46023d5616 ("tracing:
Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast"). When
a per-CPU monitor handles an event, it retrieves the monitor state using
a per-CPU pointer. If the event itself doesn't disable preemption, the
task can migrate to a different CPU and we risk updating the wrong
monitor.

Mitigate this by explicitly disabling task migration before acquiring
the monitor pointer. This cannot guarantee the monitor runs on the
correct CPU but reduces the race condition window and prevents warnings.

Reviewed-by: Wen Yang <wen.yang@linux.dev>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
 include/rv/da_monitor.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/rv/da_monitor.h b/include/rv/da_monitor.h
index 1f440c781..34b8fba9e 100644
--- a/include/rv/da_monitor.h
+++ b/include/rv/da_monitor.h
@@ -218,6 +218,10 @@ static inline void da_monitor_destroy(void)
 	da_monitor_sync_hook();
 }
 
+#ifndef da_implicit_guard
+#define da_implicit_guard()
+#endif
+
 #elif RV_MON_TYPE == RV_MON_PER_CPU
 /*
  * Functions to define, init and get a per-cpu monitor.
@@ -284,6 +288,10 @@ static inline void da_monitor_destroy(void)
 	da_monitor_sync_hook();
 }
 
+#ifndef da_implicit_guard
+#define da_implicit_guard() guard(migrate)()
+#endif
+
 #elif RV_MON_TYPE == RV_MON_PER_TASK
 /*
  * Functions to define, init and get a per-task monitor.
@@ -756,6 +764,7 @@ static inline bool __da_handle_start_run_event(struct da_monitor *da_mon,
  */
 static inline void da_handle_event(enum events event)
 {
+	da_implicit_guard();
 	__da_handle_event(da_get_monitor(), event, 0);
 }
 
@@ -771,6 +780,7 @@ static inline void da_handle_event(enum events event)
  */
 static inline bool da_handle_start_event(enum events event)
 {
+	da_implicit_guard();
 	return __da_handle_start_event(da_get_monitor(), event, 0);
 }
 
@@ -782,6 +792,7 @@ static inline bool da_handle_start_event(enum events event)
  */
 static inline bool da_handle_start_run_event(enum events event)
 {
+	da_implicit_guard();
 	return __da_handle_start_run_event(da_get_monitor(), event, 0);
 }
 
-- 
2.54.0


  parent reply	other threads:[~2026-06-01 15:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 15:38 [PATCH v4 00/13] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 01/13] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 02/13] rv: Reset per-task DA monitors before releasing the slot Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 03/13] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 04/13] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 05/13] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 06/13] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-06-02  8:52   ` Nam Cao
2026-06-01 15:38 ` [PATCH v4 07/13] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 08/13] rv: Ensure synchronous cleanup for " Gabriele Monaco
2026-06-02  9:17   ` Nam Cao
2026-06-01 15:38 ` Gabriele Monaco [this message]
2026-06-01 15:38 ` [PATCH v4 10/13] rv: Use 0 to check preemption enabled in opid Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 11/13] verification/rvgen: Fix suffix strip in dot2k Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 12/13] rv: Fix read_lock scope in per-task DA cleanup Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 13/13] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601153840.124372-10-gmonaco@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    --cc=wen.yang@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox