From: Nam Cao <namcao@linutronix.de>
To: Gabriele Monaco <gmonaco@redhat.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Gabriele Monaco <gmonaco@redhat.com>,
linux-trace-kernel@vger.kernel.org
Cc: Wen Yang <wen.yang@linux.dev>
Subject: Re: [PATCH v4 08/13] rv: Ensure synchronous cleanup for HA monitors
Date: Tue, 02 Jun 2026 11:17:51 +0200 [thread overview]
Message-ID: <87zf1dxpvk.fsf@yellow.woof> (raw)
In-Reply-To: <20260601153840.124372-9-gmonaco@redhat.com>
Gabriele Monaco <gmonaco@redhat.com> writes:
> HA monitors may start timers, all cleanup functions currently stop the
> timers asynchronously to avoid sleeping in the wrong context.
> Nothing makes sure running callbacks terminate on cleanup.
>
> Run the entire HA timer callback in an RCU read-side critical section,
> this way we can simply synchronize_rcu() with any pending timer and are
> sure any cleanup using kfree_rcu() runs after callbacks terminated.
> Additionally make sure any unlikely callback running late won't run any
> code if the monitor is marked as disabled or if destruction started.
> Use memory barriers to serialise with racing resets.
>
> Fixes: f5587d1b6ec9 ("rv: Add Hybrid Automata monitor type")
> Fixes: 4a24127bd6cb ("rv: Add support for per-object monitors in DA/HA")
> Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
Reviewed-by: Nam Cao <namcao@linutronix.de>
next prev parent reply other threads:[~2026-06-02 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 15:38 [PATCH v4 00/13] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 01/13] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 02/13] rv: Reset per-task DA monitors before releasing the slot Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 03/13] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 04/13] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 05/13] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 06/13] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-06-02 8:52 ` Nam Cao
2026-06-01 15:38 ` [PATCH v4 07/13] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 08/13] rv: Ensure synchronous cleanup for " Gabriele Monaco
2026-06-02 9:17 ` Nam Cao [this message]
2026-06-01 15:38 ` [PATCH v4 09/13] rv: Prevent task migration while handling per-CPU events Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 10/13] rv: Use 0 to check preemption enabled in opid Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 11/13] verification/rvgen: Fix suffix strip in dot2k Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 12/13] rv: Fix read_lock scope in per-task DA cleanup Gabriele Monaco
2026-06-01 15:38 ` [PATCH v4 13/13] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf1dxpvk.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox