* [PATCH] tracing: Fix logged instance name on creation failure
@ 2026-08-07 8:54 Vincent Donnefort
2026-08-07 10:05 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Vincent Donnefort @ 2026-08-07 8:54 UTC (permalink / raw)
To: rostedt, mhiramat, linux-trace-kernel
Cc: mathieu.desnoyers, kernel-team, linux-kernel, Vincent Donnefort
When boot instance creation fails, the kernel incorrectly logs "(null)"
as the instance name because strsep() consumes curr_str entirely during
parsing.
Print the properly parsed name variable instead. And while at it log
the error code.
Fixes: cb1f98c5e574 ("tracing: Add creation of instances at boot command line")
Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 01a5e87af299..26ae682021c8 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -9726,7 +9726,8 @@ __init static void enable_instances(void)
tr = trace_array_create_systems(name, NULL, addr, size);
if (IS_ERR(tr)) {
- pr_warn("Tracing: Failed to create instance buffer %s\n", curr_str);
+ pr_warn("Tracing: Failed to create instance buffer '%s' (%ld)\n", name,
+ PTR_ERR(tr));
continue;
}
base-commit: 075b74841bd0065a3bda3440873c747938e69b68
--
2.55.0.654.g21b8a5bc05-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: Fix logged instance name on creation failure
2026-08-07 8:54 [PATCH] tracing: Fix logged instance name on creation failure Vincent Donnefort
@ 2026-08-07 10:05 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2026-08-07 10:05 UTC (permalink / raw)
To: Vincent Donnefort
Cc: rostedt, linux-trace-kernel, mathieu.desnoyers, kernel-team,
linux-kernel
On Fri, 7 Aug 2026 09:54:23 +0100
Vincent Donnefort <vdonnefort@google.com> wrote:
> When boot instance creation fails, the kernel incorrectly logs "(null)"
> as the instance name because strsep() consumes curr_str entirely during
> parsing.
>
> Print the properly parsed name variable instead. And while at it log
> the error code.
>
> Fixes: cb1f98c5e574 ("tracing: Add creation of instances at boot command line")
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
Good catch!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 01a5e87af299..26ae682021c8 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -9726,7 +9726,8 @@ __init static void enable_instances(void)
>
> tr = trace_array_create_systems(name, NULL, addr, size);
> if (IS_ERR(tr)) {
> - pr_warn("Tracing: Failed to create instance buffer %s\n", curr_str);
> + pr_warn("Tracing: Failed to create instance buffer '%s' (%ld)\n", name,
> + PTR_ERR(tr));
> continue;
> }
>
>
> base-commit: 075b74841bd0065a3bda3440873c747938e69b68
> --
> 2.55.0.654.g21b8a5bc05-goog
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-07 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-07 8:54 [PATCH] tracing: Fix logged instance name on creation failure Vincent Donnefort
2026-08-07 10:05 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox