[PATCH] verification/rvgen: Use .old instead of .bak for kunit backup files

[PATCH] verification/rvgen: Use .old instead of .bak for kunit backup files

[Gabriele Monaco]

The rvgen kunit command generates .bak backup files and these can be
checked in for selftests (make check). Clean targets like make disclean
remove such files, leaving the tree dirty.

Switch to .old to preserve a clean tree after make disclean.

Reported-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Closes: https://lore.kernel.org/lkml/aosuwKH5GOEo0xTN@google.com
Fixes: 7b6246294eb0 ("verification/rvgen: Add selftests for rvgen kunit")
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
 tools/verification/rvgen/rvgen/kunit.py                         | 2 +-
 .../{test_bak_kunit_kunit.c.bak => test_bak_kunit_kunit.c.old}  | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename tools/verification/rvgen/tests/golden/test_bak_kunit/{test_bak_kunit_kunit.c.bak => test_bak_kunit_kunit.c.old} (100%)

diff --git a/tools/verification/rvgen/rvgen/kunit.py b/tools/verification/rvgen/rvgen/kunit.py
index ed2082d7d3bc..85973f918c9b 100644
--- a/tools/verification/rvgen/rvgen/kunit.py
+++ b/tools/verification/rvgen/rvgen/kunit.py
@@ -173,7 +173,7 @@ EXPORT_SYMBOL_IF_KUNIT({struct_name});
             for path in (header_file_path, kunit_c_file_path):
                 if path.exists():
                     try:
-                        path.rename(path.with_suffix(path.suffix + ".bak"))
+                        path.rename(path.with_suffix(path.suffix + ".old"))
                     except OSError as e:
                         raise KUnitError(f"Error backing up file {path}: {e}") from e
 
diff --git a/tools/verification/rvgen/tests/golden/test_bak_kunit/test_bak_kunit_kunit.c.bak b/tools/verification/rvgen/tests/golden/test_bak_kunit/test_bak_kunit_kunit.c.old
similarity index 100%
rename from tools/verification/rvgen/tests/golden/test_bak_kunit/test_bak_kunit_kunit.c.bak
rename to tools/verification/rvgen/tests/golden/test_bak_kunit/test_bak_kunit_kunit.c.old

base-commit: 0a0d1d55dad570724bf8c7ea83409639cfb4be9b
-- 
2.55.0

Re: [PATCH] verification/rvgen: Use .old instead of .bak for kunit backup files

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `rvgen kunit` tool generates `.old` backup files which are not cleaned up by `make distclean`, polluting the user's working directory.
--

--- Patch [1]: [PATCH] verification/rvgen: Use .old instead of .bak for kunit backup files ---
commit 293b444e4dfea5692931faee1bc9c58a549085d8
Author: Gabriele Monaco <gmonaco@redhat.com>

verification/rvgen: Use .old instead of .bak for kunit backup files

The rvgen kunit command generates .bak backup files and these can be
checked in for selftests (make check). Clean targets like make disclean
remove such files, leaving the tree dirty. Switch to .old to preserve a
clean tree after make disclean.

Closes: https://lore.kernel.org/lkml/aosuwKH5GOEo0xTN@google.com

> diff --git a/tools/verification/rvgen/rvgen/kunit.py b/tools/verification/rvgen/rvgen/kunit.py
> index ed2082d7d3bc4..85973f918c9b5 100644
> --- a/tools/verification/rvgen/rvgen/kunit.py
> +++ b/tools/verification/rvgen/rvgen/kunit.py
[ ... ]
> @@ -173,7 +173,7 @@ EXPORT_SYMBOL_IF_KUNIT({struct_name});
>              for path in (header_file_path, kunit_c_file_path):
>                  if path.exists():
>                      try:
> -                        path.rename(path.with_suffix(path.suffix + ".bak"))
> +                        path.rename(path.with_suffix(path.suffix + ".old"))

[Severity: Medium]
Will this regression leave users' working directories polluted with .old
backup files that aren't cleaned up by the top-level make distclean target?

The kernel's global Makefile explicitly cleans *.bak files during
distclean, but ignores *.old files.

When a user runs rvgen kunit in a directory with existing kunit files and
accepts the backup prompt, print_files() will generate these .old files.
Since they are no longer .bak files, is it expected that they will persist
after running make distclean?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824081519.81103-2-gmonaco@redhat.com?part=1

Re: [PATCH] verification/rvgen: Use .old instead of .bak for kunit backup files

[Kuan-Wei Chiu]

On Mon, Aug 24, 2026 at 10:15:19AM +0200, Gabriele Monaco wrote:
> The rvgen kunit command generates .bak backup files and these can be
> checked in for selftests (make check). Clean targets like make disclean
> remove such files, leaving the tree dirty.
> 
> Switch to .old to preserve a clean tree after make disclean.
> 
> Reported-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> Closes: https://lore.kernel.org/lkml/aosuwKH5GOEo0xTN@google.com
> Fixes: 7b6246294eb0 ("verification/rvgen: Add selftests for rvgen kunit")
> Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>

Thanks for the quick fix!
The working tree now remains clean after running make distclean.

Tested-by: Kuan-Wei Chiu <visitorckw@gmail.com>

Regards,
Kuan-Wei

> ---
>  tools/verification/rvgen/rvgen/kunit.py                         | 2 +-
>  .../{test_bak_kunit_kunit.c.bak => test_bak_kunit_kunit.c.old}  | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename tools/verification/rvgen/tests/golden/test_bak_kunit/{test_bak_kunit_kunit.c.bak => test_bak_kunit_kunit.c.old} (100%)
> 
> diff --git a/tools/verification/rvgen/rvgen/kunit.py b/tools/verification/rvgen/rvgen/kunit.py
> index ed2082d7d3bc..85973f918c9b 100644
> --- a/tools/verification/rvgen/rvgen/kunit.py
> +++ b/tools/verification/rvgen/rvgen/kunit.py
> @@ -173,7 +173,7 @@ EXPORT_SYMBOL_IF_KUNIT({struct_name});
>              for path in (header_file_path, kunit_c_file_path):
>                  if path.exists():
>                      try:
> -                        path.rename(path.with_suffix(path.suffix + ".bak"))
> +                        path.rename(path.with_suffix(path.suffix + ".old"))
>                      except OSError as e:
>                          raise KUnitError(f"Error backing up file {path}: {e}") from e
>  
> diff --git a/tools/verification/rvgen/tests/golden/test_bak_kunit/test_bak_kunit_kunit.c.bak b/tools/verification/rvgen/tests/golden/test_bak_kunit/test_bak_kunit_kunit.c.old
> similarity index 100%
> rename from tools/verification/rvgen/tests/golden/test_bak_kunit/test_bak_kunit_kunit.c.bak
> rename to tools/verification/rvgen/tests/golden/test_bak_kunit/test_bak_kunit_kunit.c.old
> 
> base-commit: 0a0d1d55dad570724bf8c7ea83409639cfb4be9b
> -- 
> 2.55.0
> 

Re: [PATCH] verification/rvgen: Use .old instead of .bak for kunit backup files

[Nam Cao]

Gabriele Monaco <gmonaco@redhat.com> writes:
> The rvgen kunit command generates .bak backup files and these can be
> checked in for selftests (make check). Clean targets like make disclean
> remove such files, leaving the tree dirty.
>
> Switch to .old to preserve a clean tree after make disclean.
>
> Reported-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> Closes: https://lore.kernel.org/lkml/aosuwKH5GOEo0xTN@google.com
> Fixes: 7b6246294eb0 ("verification/rvgen: Add selftests for rvgen kunit")
> Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>

Reviewed-by: Nam Cao <namcao@linutronix.de>

We should send it to v7.3 as soon as possible, to avoid further complains.

Nam