From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/3] tracing: Fix subbuf resize races with trace_pipe_raw readers
Date: Wed, 26 Aug 2026 14:31:23 -0400 [thread overview]
Message-ID: <20260826143123.1b3e3854@gandalf.local.home> (raw)
In-Reply-To: <ao8TQ-SvhjYgy43-@google.com>
On Wed, 26 Aug 2026 17:24:35 +0100
Vincent Donnefort <vdonnefort@google.com> wrote:
> > This is a legitimate concern. But with an easy solution. Perhaps just add:
> >
> > if (full &&
> > (!read || (len < (size - read)) ||
> > - cpu_buffer->reader_page == cpu_buffer->commit_page))
> > + cpu_buffer->reader_page == cpu_buffer->commit_page) &&
> > + data_page->order == buffer->subbuf_order)
> > return -1;
> >
> > If the user is changing the buffer size at the same time as reading raw
> > pages, they get what they deserve! I just don't want to let the kernel go
> > into an infinite loop.
> >
> > -- Steve
> >
>
> Sounds good. Do you prefer to get a v9 or you fold this into the existing commit?
>
Please send a v9. It makes the patchwork flow much better. If I modify a
patch, it makes patchwork not be able to automate the status updates as it
moves around git trees.
Thanks,
-- Steve
next prev parent reply other threads:[~2026-08-26 18:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 9:45 [PATCH v8 0/3] ring-buffer: Fixes for subbuf resizing and persistent buffers Vincent Donnefort
2026-08-26 9:45 ` [PATCH v8 1/3] tracing: Fix subbuf resize races with trace_pipe_raw readers Vincent Donnefort
2026-08-26 9:59 ` sashiko-bot
2026-08-26 14:37 ` Steven Rostedt
2026-08-26 16:24 ` Vincent Donnefort
2026-08-26 18:31 ` Steven Rostedt [this message]
2026-08-27 6:31 ` Vincent Donnefort
2026-08-27 13:15 ` Steven Rostedt
2026-08-27 16:21 ` Vincent Donnefort
2026-08-27 19:33 ` Steven Rostedt
2026-08-28 8:24 ` Vincent Donnefort
2026-08-28 8:36 ` Steven Rostedt
2026-08-26 9:45 ` [PATCH v8 2/3] ring-buffer: Cap static ring buffer nr_pages Vincent Donnefort
2026-08-26 9:45 ` [PATCH v8 3/3] ring-buffer: Prevent truncation of nr_pages / nr_subbufs Vincent Donnefort
2026-08-26 10:02 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826143123.1b3e3854@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox