From: Vincent Donnefort <vdonnefort@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/3] tracing: Fix subbuf resize races with trace_pipe_raw readers
Date: Fri, 28 Aug 2026 09:24:36 +0100 [thread overview]
Message-ID: <apFFxOw_DUUChws5@google.com> (raw)
In-Reply-To: <20260827153314.77218528@gandalf.local.home>
On Thu, Aug 27, 2026 at 03:33:14PM -0400, Steven Rostedt wrote:
> On Thu, 27 Aug 2026 17:21:39 +0100
> Vincent Donnefort <vdonnefort@google.com> wrote:
>
> > On Thu, Aug 27, 2026 at 09:15:41AM -0400, Steven Rostedt wrote:
> > > On Thu, 27 Aug 2026 07:31:23 +0100
> > > Vincent Donnefort <vdonnefort@google.com> wrote:
> > >
> > > > Looking at the function again, shouldn't we add !rb_is_static(cpu_buffer) as
> > > > well to the full page test?
> > >
> > > Why?
> > >
> > > -- Steve
> >
> > So that the splice can make progress when the ring-buffer is presistent or
> > user-mapped. Or do we say that's expected behaviour?
> >
>
> Ah yeah, I see. Hmm, looking at the code to see how this would work, I
> think I found another bug. Let me look deeper into it.
>
> -- Steve
A bug if we allow rb_is_static()?
If not, shall I add it to my series?
--
Vincent
next prev parent reply other threads:[~2026-08-28 8:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 9:45 [PATCH v8 0/3] ring-buffer: Fixes for subbuf resizing and persistent buffers Vincent Donnefort
2026-08-26 9:45 ` [PATCH v8 1/3] tracing: Fix subbuf resize races with trace_pipe_raw readers Vincent Donnefort
2026-08-26 9:59 ` sashiko-bot
2026-08-26 14:37 ` Steven Rostedt
2026-08-26 16:24 ` Vincent Donnefort
2026-08-26 18:31 ` Steven Rostedt
2026-08-27 6:31 ` Vincent Donnefort
2026-08-27 13:15 ` Steven Rostedt
2026-08-27 16:21 ` Vincent Donnefort
2026-08-27 19:33 ` Steven Rostedt
2026-08-28 8:24 ` Vincent Donnefort [this message]
2026-08-28 8:36 ` Steven Rostedt
2026-08-26 9:45 ` [PATCH v8 2/3] ring-buffer: Cap static ring buffer nr_pages Vincent Donnefort
2026-08-26 9:45 ` [PATCH v8 3/3] ring-buffer: Prevent truncation of nr_pages / nr_subbufs Vincent Donnefort
2026-08-26 10:02 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apFFxOw_DUUChws5@google.com \
--to=vdonnefort@google.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox