Linux Trace Kernel
 help / color / mirror / Atom feed
* [PATCH] cachefiles: Remove unused cachefiles_prep_read tracepoint
@ 2026-11-16 15:48 Temitope obabi
  0 siblings, 0 replies; only message in thread
From: Temitope obabi @ 2026-11-16 15:48 UTC (permalink / raw)
  To: rostedt, mhiramat
  Cc: mathieu.desnoyers, ast, daniel, andrii, dhowells, brauner,
	linux-kernel, linux-trace-kernel, bpf, Temitope obabi

Nothing calls trace_cachefiles_prep_read(), so the tracepoint is
unused. Remove it, along with the cachefiles_prepare_read_trace enum
and its name table, and the entry in the BPF raw tracepoint null-args
table, which exist only for this tracepoint.

Fixes: c990057233d1 ("cachefiles: Don't rely on backing fs storage map for most use cases")
Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
---
 include/trace/events/cachefiles.h | 64 -------------------------------
 kernel/bpf/btf.c                  |  1 -
 2 files changed, 65 deletions(-)

diff --git a/include/trace/events/cachefiles.h b/include/trace/events/cachefiles.h
index a19233e8ae78..8380a4156c4e 100644
--- a/include/trace/events/cachefiles.h
+++ b/include/trace/events/cachefiles.h
@@ -72,17 +72,6 @@ enum cachefiles_trunc_trace {
 	cachefiles_trunc_zap,
 };
 
-enum cachefiles_prepare_read_trace {
-	cachefiles_trace_read_after_eof,
-	cachefiles_trace_read_found_hole,
-	cachefiles_trace_read_found_part,
-	cachefiles_trace_read_have_data,
-	cachefiles_trace_read_no_data,
-	cachefiles_trace_read_no_file,
-	cachefiles_trace_read_seek_error,
-	cachefiles_trace_read_seek_nxio,
-};
-
 enum cachefiles_error_trace {
 	cachefiles_trace_alignment_error,
 	cachefiles_trace_create_nospace,
@@ -163,16 +152,6 @@ enum cachefiles_error_trace {
 	EM(cachefiles_trunc_shrink,		"SHRINK")		\
 	E_(cachefiles_trunc_zap,		"ZAP   ")
 
-#define cachefiles_prepare_read_traces					\
-	EM(cachefiles_trace_read_after_eof,	"after-eof ")		\
-	EM(cachefiles_trace_read_found_hole,	"found-hole")		\
-	EM(cachefiles_trace_read_found_part,	"found-part")		\
-	EM(cachefiles_trace_read_have_data,	"have-data ")		\
-	EM(cachefiles_trace_read_no_data,	"no-data   ")		\
-	EM(cachefiles_trace_read_no_file,	"no-file   ")		\
-	EM(cachefiles_trace_read_seek_error,	"seek-error")		\
-	E_(cachefiles_trace_read_seek_nxio,	"seek-enxio")
-
 #define cachefiles_error_traces						\
 	EM(cachefiles_trace_alignment_error,	"align")		\
 	EM(cachefiles_trace_create_nospace,	"create-nospace")	\
@@ -210,7 +189,6 @@ cachefiles_obj_kill_traces;
 cachefiles_obj_ref_traces;
 cachefiles_coherency_traces;
 cachefiles_trunc_traces;
-cachefiles_prepare_read_traces;
 cachefiles_error_traces;
 
 /*
@@ -468,48 +446,6 @@ TRACE_EVENT(cachefiles_vol_coherency,
 		      __entry->ino)
 	    );
 
-TRACE_EVENT(cachefiles_prep_read,
-	    TP_PROTO(struct cachefiles_object *obj,
-		     uoff_t start,
-		     size_t len,
-		     unsigned short flags,
-		     enum netfs_io_source source,
-		     enum cachefiles_prepare_read_trace why,
-		     ino_t cache_inode, ino_t netfs_inode),
-
-	    TP_ARGS(obj, start, len, flags, source, why, cache_inode, netfs_inode),
-
-	    TP_STRUCT__entry(
-		    __field(unsigned int,		obj)
-		    __field(unsigned short,		flags)
-		    __field(enum netfs_io_source,	source)
-		    __field(enum cachefiles_prepare_read_trace,	why)
-		    __field(size_t,			len)
-		    __field(uoff_t,			start)
-		    __field(unsigned int,		netfs_inode)
-		    __field(unsigned int,		cache_inode)
-			     ),
-
-	    TP_fast_assign(
-		    __entry->obj	= obj ? obj->debug_id : 0;
-		    __entry->flags	= flags;
-		    __entry->source	= source;
-		    __entry->why	= why;
-		    __entry->len	= len;
-		    __entry->start	= start;
-		    __entry->netfs_inode = netfs_inode;
-		    __entry->cache_inode = cache_inode;
-			   ),
-
-	    TP_printk("o=%08x %s %s f=%02x s=%llx %zx ni=%x B=%x",
-		      __entry->obj,
-		      __print_symbolic(__entry->source, netfs_sreq_sources),
-		      __print_symbolic(__entry->why, cachefiles_prepare_read_traces),
-		      __entry->flags,
-		      __entry->start, __entry->len,
-		      __entry->netfs_inode, __entry->cache_inode)
-	    );
-
 TRACE_EVENT(cachefiles_read,
 	    TP_PROTO(struct cachefiles_object *obj,
 		     struct inode *backer,
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 538129ed2418..c6403edf97a4 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -7264,7 +7264,6 @@ static const struct bpf_raw_tp_null_args raw_tp_null_args[] = {
 	{ "cachefiles_lookup", 0x1 | 0x200 },
 	{ "cachefiles_unlink", 0x1 },
 	{ "cachefiles_rename", 0x1 },
-	{ "cachefiles_prep_read", 0x1 },
 	{ "cachefiles_mark_active", 0x1 },
 	{ "cachefiles_mark_failed", 0x1 },
 	{ "cachefiles_mark_inactive", 0x1 },
-- 
2.53.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-16 15:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 15:48 [PATCH] cachefiles: Remove unused cachefiles_prep_read tracepoint Temitope obabi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox