From: Steven Rostedt <rostedt@goodmis.org>
To: sashiko-bot@kernel.org
Cc: sashiko-reviews@lists.linux.dev,
"Brian Norris" <briannorris@chromium.org>,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
Date: Tue, 17 Nov 2026 08:55:52 -0500 [thread overview]
Message-ID: <20261117085552.0e4ef272@gandalf.local.home> (raw)
In-Reply-To: <sashiko-outbox-217828@kernel.org>
On Mon, 16 Nov 2026 22:58:01 +0000
sashiko-bot@kernel.org wrote:
> [Severity: Low]
> Should FTRACE_STARTUP_TEST depend on TRACING (or select TRACING) instead
> of selecting GENERIC_TRACER?
>
> GENERIC_TRACER is meant only for full tracer options so that
> ENABLE_DEFAULT_TRACERS is hidden when a full tracer is enabled:
>
> kernel/trace/Kconfig:
> # All tracer options should select GENERIC_TRACER. For those options that are
> # enabled by all tracers (context switch and event tracer) they select TRACING.
> ...
> config ENABLE_DEFAULT_TRACERS
> bool "Trace process context switches and events"
> depends on !GENERIC_TRACER
> select TRACING
>
> Because FTRACE_STARTUP_TEST is a test option rather than a tracer, having
> it select GENERIC_TRACER disables and hides ENABLE_DEFAULT_TRACERS when no
> full tracer is configured, and implicitly pulls in TRACING even when all
> tracers are disabled.
Actually, the selftests should depend on TRACING and not GENERIC_TRACER. It
may have been that the self tests were added before the trace events.
But it should not "select" a config. The selftest are only to be selected
if there is something to test.
-- Steve
next prev parent reply other threads:[~2026-11-17 13:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
2026-11-16 22:58 ` sashiko-bot
2026-11-17 13:55 ` Steven Rostedt [this message]
2026-11-17 18:23 ` Brian Norris
2026-11-17 18:36 ` sashiko-bot
2026-11-17 18:42 ` Brian Norris
2026-11-17 19:22 ` Steven Rostedt
2026-11-17 19:23 ` Steven Rostedt
2026-11-17 13:53 ` Steven Rostedt
2026-11-17 17:45 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117085552.0e4ef272@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=briannorris@chromium.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox