Linux Trace Kernel
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
Date: Tue, 17 Nov 2026 10:42:01 -0800	[thread overview]
Message-ID: <avyf-arwNO74QFip@google.com> (raw)
In-Reply-To: <sashiko-outbox-219362@kernel.org>

On Tue, Nov 17, 2026 at 06:36:09PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issues to consider:
> - [High] tracing: missing Signed-off-by trailer and unformatted email
>   reply changelog
> - [Low] tracing: ENABLE_DEFAULT_TRACERS stays unselected for direct
>   TRACING selectors
> --
> > Anyway, my point is that it's not exactly straightforward to enable the
> > features you want and get the tests you want.
> >
> > I've appended a diff that seems a bit more user-friendly to me. It
> > makes it more explicit in the menu how event-tracing is forced-on by
> > many other tracers, but is user-configurable when it's not forced. I can
> > formally submit it (in 2 patches) if you'd like.

Well clearly sashiko still points out issues here. But I still maintain
that the config menu here is confusing and hard to use. I'll see if I
can come up with a better solution, or else just accept the
un-friendliness.

Brian

  reply	other threads:[~2026-11-17 18:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
2026-11-16 22:58 ` sashiko-bot
2026-11-17 13:55   ` Steven Rostedt
2026-11-17 18:23     ` Brian Norris
2026-11-17 18:36       ` sashiko-bot
2026-11-17 18:42         ` Brian Norris [this message]
2026-11-17 13:53 ` Steven Rostedt
2026-11-17 17:45   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avyf-arwNO74QFip@google.com \
    --to=briannorris@chromium.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox