Linux Trace Kernel
 help / color / mirror / Atom feed
* [PATCH] ftrace: Do not WARN on a function probe glob that starts with '!'
@ 2026-11-18  3:26 Yifan Feng
  0 siblings, 0 replies; only message in thread
From: Yifan Feng @ 2026-11-18  3:26 UTC (permalink / raw)
  To: Steven Rostedt, Masami Hiramatsu
  Cc: Mark Rutland, Mathieu Desnoyers, linux-trace-kernel, linux-kernel,
	Yifan Feng

Removing a function probe with a second '!' in front of the glob
triggers a WARN_ON() in unregister_ftrace_function_probe_func():

  # echo '!!vfs_read:traceoff' >> set_ftrace_filter
  WARNING: kernel/trace/ftrace.c:5675 at unregister_ftrace_function_probe_func+0x662/0x870

The callback strips the first '!' and filter_parse_regex() then reports
the second one as a negated glob. This is plain bad input from user
space, so return -EINVAL without the warning.

Fixes: 23b4ff3aa479 ("ftrace: add traceon traceoff commands to enable/disable the buffers")
Signed-off-by: Yifan Feng <evanfengff@gmail.com>
---
Tested on v7.4-rc3 in QEMU: WARNING and taint before, -EINVAL only after.
Found and written with the help of an AI coding assistant.

 kernel/trace/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index c7d74b33d36d..04ea82a18601 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -5672,7 +5672,7 @@ unregister_ftrace_function_probe_func(char *glob, struct trace_array *tr,
 		func_g.len = strlen(func_g.search);
 
 		/* we do not support '!' for function probes */
-		if (WARN_ON(not))
+		if (not)
 			return -EINVAL;
 	}
 

base-commit: 7ccb044c27720d48175577080b851f047ddcfd1c
-- 
2.39.3 (Apple Git-146)


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-18  3:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  3:26 [PATCH] ftrace: Do not WARN on a function probe glob that starts with '!' Yifan Feng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox