From: Shuah Khan <skhan@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>, Ayush Jain <Ayush.jain3@amd.com>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, Naveen.Rao@amd.com,
Kalpana.Shetty@amd.com, Narasimhan.V@amd.com,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests/ftrace: Convert poll to a gen_file
Date: Fri, 9 May 2025 11:03:39 -0600 [thread overview]
Message-ID: <4f3eeda9-b9d0-41f6-8a05-b845cf020b76@linuxfoundation.org> (raw)
In-Reply-To: <20250507152653.4af2549a@gandalf.local.home>
On 5/7/25 13:26, Steven Rostedt wrote:
>
> Shuah,
>
> Can you take this through your tree?
>
> -- Steve
>
>
> On Wed, 9 Apr 2025 12:48:55 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> On Wed, 9 Apr 2025 04:46:32 +0000
>> Ayush Jain <Ayush.jain3@amd.com> wrote:
>>
>>> Poll program is a helper to ftracetest, thus make it a
>>> generic file and remove it from being run as a test.
>>>
>>> Currently when executing tests using
>>> $ make run_tests
>>> CC poll
>>> TAP version 13
>>> 1..2
>>> # timeout set to 0
>>> # selftests: ftrace: poll
>>> # Error: Polling file is not specified
>>> not ok 1 selftests: ftrace: poll # exit=255
>>>
>>> Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
>>> rather than as a test.
>>>
>>> Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
>>>
>>> Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
>>
>> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>>
>> -- Steve
Yes - I will take this through my tree.
thanks,
-- Shuah
prev parent reply other threads:[~2025-05-09 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 4:46 [PATCH v2] selftests/ftrace: Convert poll to a gen_file Ayush Jain
2025-04-09 16:48 ` Steven Rostedt
2025-05-07 19:26 ` Steven Rostedt
2025-05-09 17:03 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3eeda9-b9d0-41f6-8a05-b845cf020b76@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Ayush.jain3@amd.com \
--cc=Kalpana.Shetty@amd.com \
--cc=Narasimhan.V@amd.com \
--cc=Naveen.Rao@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox