Linux Trace Kernel
 help / color / mirror / Atom feed
From: Ayush Jain <Ayush.jain3@amd.com>
To: <rostedt@goodmis.org>, <mhiramat@kernel.org>,
	<mathieu.desnoyers@efficios.com>, <linux-kernel@vger.kernel.org>,
	<linux-trace-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
Cc: <Naveen.Rao@amd.com>, <Kalpana.Shetty@amd.com>,
	<Narasimhan.V@amd.com>, Ayush Jain <Ayush.jain3@amd.com>
Subject: [PATCH v2] selftests/ftrace: Convert poll to a gen_file
Date: Wed, 9 Apr 2025 04:46:32 +0000	[thread overview]
Message-ID: <20250409044632.363285-1-Ayush.jain3@amd.com> (raw)

Poll program is a helper to ftracetest, thus make it a
generic file and remove it from being run as a test.

Currently when executing tests using
    $ make run_tests
      CC       poll
    TAP version 13
    1..2
    # timeout set to 0
    # selftests: ftrace: poll
    # Error: Polling file is not specified
    not ok 1 selftests: ftrace: poll # exit=255

Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
rather than as a test.

Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")

Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
---
 tools/testing/selftests/ftrace/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
index 49d96bb16355..7c12263f8260 100644
--- a/tools/testing/selftests/ftrace/Makefile
+++ b/tools/testing/selftests/ftrace/Makefile
@@ -6,6 +6,6 @@ TEST_PROGS := ftracetest-ktap
 TEST_FILES := test.d settings
 EXTRA_CLEAN := $(OUTPUT)/logs/*
 
-TEST_GEN_PROGS = poll
+TEST_GEN_FILES := poll
 
 include ../lib.mk
-- 
2.34.1


             reply	other threads:[~2025-04-09  4:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09  4:46 Ayush Jain [this message]
2025-04-09 16:48 ` [PATCH v2] selftests/ftrace: Convert poll to a gen_file Steven Rostedt
2025-05-07 19:26   ` Steven Rostedt
2025-05-09 17:03     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250409044632.363285-1-Ayush.jain3@amd.com \
    --to=ayush.jain3@amd.com \
    --cc=Kalpana.Shetty@amd.com \
    --cc=Narasimhan.V@amd.com \
    --cc=Naveen.Rao@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox