[PATCH v2] selftests/ftrace: Convert poll to a gen_file

[PATCH v2] selftests/ftrace: Convert poll to a gen_file

[Ayush Jain]

Poll program is a helper to ftracetest, thus make it a
generic file and remove it from being run as a test.

Currently when executing tests using
    $ make run_tests
      CC       poll
    TAP version 13
    1..2
    # timeout set to 0
    # selftests: ftrace: poll
    # Error: Polling file is not specified
    not ok 1 selftests: ftrace: poll # exit=255

Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
rather than as a test.

Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")

Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
---
 tools/testing/selftests/ftrace/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
index 49d96bb16355..7c12263f8260 100644
--- a/tools/testing/selftests/ftrace/Makefile
+++ b/tools/testing/selftests/ftrace/Makefile
@@ -6,6 +6,6 @@ TEST_PROGS := ftracetest-ktap
 TEST_FILES := test.d settings
 EXTRA_CLEAN := $(OUTPUT)/logs/*
 
-TEST_GEN_PROGS = poll
+TEST_GEN_FILES := poll
 
 include ../lib.mk
-- 
2.34.1

Re: [PATCH v2] selftests/ftrace: Convert poll to a gen_file

[Steven Rostedt]

On Wed, 9 Apr 2025 04:46:32 +0000
Ayush Jain <Ayush.jain3@amd.com> wrote:

> Poll program is a helper to ftracetest, thus make it a
> generic file and remove it from being run as a test.
> 
> Currently when executing tests using
>     $ make run_tests
>       CC       poll
>     TAP version 13
>     1..2
>     # timeout set to 0
>     # selftests: ftrace: poll
>     # Error: Polling file is not specified
>     not ok 1 selftests: ftrace: poll # exit=255
> 
> Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
> rather than as a test.
> 
> Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
> 
> Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

> ---
>  tools/testing/selftests/ftrace/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
> index 49d96bb16355..7c12263f8260 100644
> --- a/tools/testing/selftests/ftrace/Makefile
> +++ b/tools/testing/selftests/ftrace/Makefile
> @@ -6,6 +6,6 @@ TEST_PROGS := ftracetest-ktap
>  TEST_FILES := test.d settings
>  EXTRA_CLEAN := $(OUTPUT)/logs/*
>  
> -TEST_GEN_PROGS = poll
> +TEST_GEN_FILES := poll
>  
>  include ../lib.mk

Re: [PATCH v2] selftests/ftrace: Convert poll to a gen_file

[Steven Rostedt]

Shuah,

Can you take this through your tree?

-- Steve


On Wed, 9 Apr 2025 12:48:55 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 9 Apr 2025 04:46:32 +0000
> Ayush Jain <Ayush.jain3@amd.com> wrote:
> 
> > Poll program is a helper to ftracetest, thus make it a
> > generic file and remove it from being run as a test.
> > 
> > Currently when executing tests using
> >     $ make run_tests
> >       CC       poll
> >     TAP version 13
> >     1..2
> >     # timeout set to 0
> >     # selftests: ftrace: poll
> >     # Error: Polling file is not specified
> >     not ok 1 selftests: ftrace: poll # exit=255
> > 
> > Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
> > rather than as a test.
> > 
> > Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
> > 
> > Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>  
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve
> 
> > ---
> >  tools/testing/selftests/ftrace/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
> > index 49d96bb16355..7c12263f8260 100644
> > --- a/tools/testing/selftests/ftrace/Makefile
> > +++ b/tools/testing/selftests/ftrace/Makefile
> > @@ -6,6 +6,6 @@ TEST_PROGS := ftracetest-ktap
> >  TEST_FILES := test.d settings
> >  EXTRA_CLEAN := $(OUTPUT)/logs/*
> >  
> > -TEST_GEN_PROGS = poll
> > +TEST_GEN_FILES := poll
> >  
> >  include ../lib.mk  
> 

Re: [PATCH v2] selftests/ftrace: Convert poll to a gen_file

[Shuah Khan]

On 5/7/25 13:26, Steven Rostedt wrote:
> 
> Shuah,
> 
> Can you take this through your tree?
> 
> -- Steve
> 
> 
> On Wed, 9 Apr 2025 12:48:55 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> On Wed, 9 Apr 2025 04:46:32 +0000
>> Ayush Jain <Ayush.jain3@amd.com> wrote:
>>
>>> Poll program is a helper to ftracetest, thus make it a
>>> generic file and remove it from being run as a test.
>>>
>>> Currently when executing tests using
>>>      $ make run_tests
>>>        CC       poll
>>>      TAP version 13
>>>      1..2
>>>      # timeout set to 0
>>>      # selftests: ftrace: poll
>>>      # Error: Polling file is not specified
>>>      not ok 1 selftests: ftrace: poll # exit=255
>>>
>>> Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
>>> rather than as a test.
>>>
>>> Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
>>>
>>> Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
>>
>> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>>
>> -- Steve

Yes - I will take this through my tree.

thanks,
-- Shuah