* [PATCH] selftests/ftrace: Add nice dependency
@ 2026-10-15 2:23 Jaewon Jung
2026-10-15 14:55 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: Jaewon Jung @ 2026-10-15 2:23 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers, Shuah Khan
Cc: linux-kernel, linux-trace-kernel, linux-kselftest
The tests use nice but do not list it as a requirement.
Add nice to the requirements so the tests are unresolved, not failed,
when it is not available.
Signed-off-by: Jaewon Jung <jaewon8868@gmail.com>
---
.../test.d/trigger/inter-event/trigger-onchange-action-hist.tc | 2 +-
.../test.d/trigger/inter-event/trigger-snapshot-action-hist.tc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
index 55ab0270e5f7..04e6db2a734d 100644
--- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
+++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: GPL-2.0
# description: event trigger - test inter-event histogram trigger onchange action
-# requires: set_event "onchange(var)":README ping:program
+# requires: set_event "onchange(var)":README ping:program nice:program
# flags: instance
fail() { #msg
diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
index 9eb37c2fa417..64bb0dca7e3b 100644
--- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
+++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: GPL-2.0
# description: event trigger - test inter-event histogram trigger snapshot action
-# requires: set_event snapshot events/sched/sched_process_fork/hist "onchange(var)":README "snapshot()":README ping:program
+# requires: set_event snapshot events/sched/sched_process_fork/hist "onchange(var)":README "snapshot()":README ping:program nice:program
# flags: instance
fail() { #msg
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/ftrace: Add nice dependency
2026-10-15 2:23 [PATCH] selftests/ftrace: Add nice dependency Jaewon Jung
@ 2026-10-15 14:55 ` Masami Hiramatsu
2026-10-15 15:12 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Masami Hiramatsu @ 2026-10-15 14:55 UTC (permalink / raw)
To: Jaewon Jung
Cc: Steven Rostedt, Mathieu Desnoyers, Shuah Khan, linux-kernel,
linux-trace-kernel, linux-kselftest
On Thu, 15 Oct 2026 11:23:39 +0900, Jaewon Jung <jaewon8868@gmail.com> wrote:
> The tests use nice but do not list it as a requirement.
> Add nice to the requirements so the tests are unresolved, not failed,
> when it is not available.
>
> Signed-off-by: Jaewon Jung <jaewon8868@gmail.com>
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Shuah, will you pick this via your selftest branch?
Thank you,
> ---
> .../test.d/trigger/inter-event/trigger-onchange-action-hist.tc | 2 +-
> .../test.d/trigger/inter-event/trigger-snapshot-action-hist.tc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> index 55ab0270e5f7..04e6db2a734d 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: event trigger - test inter-event histogram trigger onchange action
> -# requires: set_event "onchange(var)":README ping:program
> +# requires: set_event "onchange(var)":README ping:program nice:program
> # flags: instance
>
> fail() { #msg
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
> index 9eb37c2fa417..64bb0dca7e3b 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: event trigger - test inter-event histogram trigger snapshot action
> -# requires: set_event snapshot events/sched/sched_process_fork/hist "onchange(var)":README "snapshot()":README ping:program
> +# requires: set_event snapshot events/sched/sched_process_fork/hist "onchange(var)":README "snapshot()":README ping:program nice:program
> # flags: instance
>
> fail() { #msg
> --
> 2.43.0
>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/ftrace: Add nice dependency
2026-10-15 14:55 ` Masami Hiramatsu
@ 2026-10-15 15:12 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2026-10-15 15:12 UTC (permalink / raw)
To: Masami Hiramatsu (Google), Jaewon Jung
Cc: Steven Rostedt, Mathieu Desnoyers, Shuah Khan, linux-kernel,
linux-trace-kernel, linux-kselftest, Shuah Khan
On 10/15/26 08:55, Masami Hiramatsu (Google) wrote:
> On Thu, 15 Oct 2026 11:23:39 +0900, Jaewon Jung <jaewon8868@gmail.com> wrote:
>> The tests use nice but do not list it as a requirement.
>> Add nice to the requirements so the tests are unresolved, not failed,
>> when it is not available.
>>
>> Signed-off-by: Jaewon Jung <jaewon8868@gmail.com>
>
> Looks good to me.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Shuah, will you pick this via your selftest branch?
>
Applied to kselftest next for Linux 7.4-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-15 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-15 2:23 [PATCH] selftests/ftrace: Add nice dependency Jaewon Jung
2026-10-15 14:55 ` Masami Hiramatsu
2026-10-15 15:12 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox