From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] rv/rtapp/sleep: Make the error more informative for user
Date: Wed, 01 Jul 2026 14:26:51 +0200 [thread overview]
Message-ID: <9bc739eec41b6616e9f81cbe50759cefb1c3ad9c.camel@redhat.com> (raw)
In-Reply-To: <d97b4b5c476e5792b6875ec9bbf8dc214f999516.1781852967.git.namcao@linutronix.de>
On Fri, 2026-06-19 at 09:21 +0200, Nam Cao wrote:
> -static void handle_sched_wakeup(void *data, struct task_struct *task)
> +static void handle_sched_exit(void *data, bool is_switch)
> {
> - ltl_atom_pulse(task, LTL_WAKE, true);
> + ltl_atom_pulse(current, LTL_SCHEDULE_IN, true);
> }
Well, this triggers also in a spurious schedule: current -> current, can
that be a problem? Otherwise you may either use sched_switch over next
or pulse only if is_switch.
It probably isn't a big deal though, since there's no SLEEP prior.. But
we may want to avoid the noise.
Looks good overall.
Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>
Thanks,
Gabriele
next prev parent reply other threads:[~2026-07-01 12:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 7:21 [PATCH v2 0/4] rv: rtapp monitor update Nam Cao
2026-06-19 7:21 ` [PATCH v2 1/4] rv/rtapp/sleep: Make the error more informative for user Nam Cao
2026-07-01 12:26 ` Gabriele Monaco [this message]
2026-07-01 12:34 ` Gabriele Monaco
2026-06-19 7:21 ` [PATCH v2 2/4] rv/rtapp/sleep: Update nanosleep rule Nam Cao
2026-07-01 12:29 ` Gabriele Monaco
2026-06-19 7:21 ` [PATCH v2 3/4] rv/rtapp/sleep: Stop monitoring kernel threads Nam Cao
2026-07-01 13:02 ` Gabriele Monaco
2026-06-19 7:21 ` [PATCH v2 4/4] rv/rtapp: Add wakeup monitor Nam Cao
2026-07-01 13:11 ` Gabriele Monaco
2026-07-02 7:25 ` Nam Cao
2026-07-02 12:12 ` Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bc739eec41b6616e9f81cbe50759cefb1c3ad9c.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox