* [PATCH v3 2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test
@ 2023-06-21 6:34 sunliming
2023-06-22 20:24 ` Beau Belgrave
0 siblings, 1 reply; 2+ messages in thread
From: sunliming @ 2023-06-21 6:34 UTC (permalink / raw)
To: rostedt, mhiramat, beaub
Cc: kelulanainsley, linux-trace-kernel, linux-kernel, sunliming
The user_event has not be enabled in write_fault test in ftrace
self-test, Just enable it.
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
tools/testing/selftests/user_events/ftrace_test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
index abfb49558a26..d33bd31425db 100644
--- a/tools/testing/selftests/user_events/ftrace_test.c
+++ b/tools/testing/selftests/user_events/ftrace_test.c
@@ -373,6 +373,10 @@ TEST_F(user, write_fault) {
ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, ®));
ASSERT_EQ(0, reg.write_index);
+ /* Enable event */
+ self->enable_fd = open(enable_file, O_RDWR);
+ ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
+
/* Write should work normally */
ASSERT_NE(-1, writev(self->data_fd, (const struct iovec *)io, 2));
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test
2023-06-21 6:34 [PATCH v3 2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test sunliming
@ 2023-06-22 20:24 ` Beau Belgrave
0 siblings, 0 replies; 2+ messages in thread
From: Beau Belgrave @ 2023-06-22 20:24 UTC (permalink / raw)
To: sunliming
Cc: rostedt, mhiramat, kelulanainsley, linux-trace-kernel,
linux-kernel
On Wed, Jun 21, 2023 at 02:34:38PM +0800, sunliming wrote:
> The user_event has not be enabled in write_fault test in ftrace
> self-test, Just enable it.
>
> Signed-off-by: sunliming <sunliming@kylinos.cn>
Good catch.
Acked-by: Beau Belgrave <beaub@linux.microsoft.com>
Thanks!
> ---
> tools/testing/selftests/user_events/ftrace_test.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
> index abfb49558a26..d33bd31425db 100644
> --- a/tools/testing/selftests/user_events/ftrace_test.c
> +++ b/tools/testing/selftests/user_events/ftrace_test.c
> @@ -373,6 +373,10 @@ TEST_F(user, write_fault) {
> ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, ®));
> ASSERT_EQ(0, reg.write_index);
>
> + /* Enable event */
> + self->enable_fd = open(enable_file, O_RDWR);
> + ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
> +
> /* Write should work normally */
> ASSERT_NE(-1, writev(self->data_fd, (const struct iovec *)io, 2));
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-22 20:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21 6:34 [PATCH v3 2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test sunliming
2023-06-22 20:24 ` Beau Belgrave
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox