Re: [PATCHv5 bpf-next 08/28] bpf: Add struct bpf_tramp_node object

[Jiri Olsa <olsajiri@gmail.com>]

On Sat, Apr 18, 2026 at 06:10:55AM +0000, bot+bpf-ci@kernel.org wrote:
> > diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c
> > index 50103b3794fb..b97d9f68fc40 100644
> > --- a/arch/powerpc/net/bpf_jit_comp.c
> > +++ b/arch/powerpc/net/bpf_jit_comp.c
> 
> [ ... ]
> 
> > @@ -827,14 +827,14 @@ static void bpf_trampoline_restore_args_stack(u32 *image, struct codegen_context
> >  static int __arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *rw_image,
> >  					 void *rw_image_end, void *ro_image,
> >  					 const struct btf_func_model *m, u32 flags,
> > -					 struct bpf_tramp_links *tlinks,
> > +					 struct bpf_tramp_nodes *tnodes,
> >  					 void *func_addr)
> >  {
> >  	int regs_off, func_meta_off, ip_off, run_ctx_off, retval_off;
> >  	int nvr_off, alt_lr_off, r4_off = 0;
> > -	struct bpf_tramp_links *fmod_ret = &tlinks[BPF_TRAMP_MODIFY_RETURN];
> > -	struct bpf_tramp_links *fentry = &tlinks[BPF_TRAMP_FENTRY];
> > -	struct bpf_tramp_links *fexit = &tlinks[BPF_TRAMP_FEXIT];
> > +	struct bpf_tramp_nodes *fmod_ret = &tnodes[BPF_TRAMP_MODIFY_RETURN];
> > +	struct bpf_tramp_nodes *fentry = &tnodes[BPF_TRAMP_FENTRY];
> > +	struct bpf_tramp_nodes *fexit = &tnodes[BPF_TRAMP_FEXIT];
> >  	int i, ret, nr_regs, retaddr_off, bpf_frame_size = 0;
> >  	struct codegen_context codegen_ctx, *ctx;
> >  	int cookie_off, cookie_cnt, cookie_ctx_off;
> > -	int fsession_cnt = bpf_fsession_cnt(tlinks);
> > +	int fsession_cnt = bpf_fsession_cnt(tnodes);
>                                             ^^^^^
> 
> This line wasn't actually updated in the diff. The parameter was renamed from
> tlinks to tnodes, but this call site still references the old name. Does this
> compile?
> 
> The same issue appears later in the function:
> 
> >  	cookie_off = bpf_frame_size;
> > -	cookie_cnt = bpf_fsession_cookie_cnt(tlinks);
> > +	cookie_cnt = bpf_fsession_cookie_cnt(tnodes);

ugh, it clashed with latest update for fsession,
and I skip the build test for some reason, will fix

jirka