From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>,
linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Thomas Weissschuh <thomas.weissschuh@linutronix.de>,
Tomas Glozar <tglozar@redhat.com>, John Kacur <jkacur@redhat.com>,
Wen Yang <wen.yang@linux.dev>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v3 14/17] verification/rvgen: Add selftests for rvgen kunit
Date: Thu, 09 Jul 2026 17:52:20 +0200 [thread overview]
Message-ID: <b50ff177c4ddd4521627cabd67ed9df638f850ed.camel@redhat.com> (raw)
In-Reply-To: <87a4s0fuqx.fsf@yellow.woof>
On Thu, 2026-07-09 at 10:11 +0200, Nam Cao wrote:
> Gabriele Monaco <gmonaco@redhat.com> writes:
> > The rvgen kunit command patches monitor files and adds necessary
> > definitions for kunit tests.
> >
> > Add a test case validating its behaviour on dummy generated files and
> > comparing it against reference files, like it's done for rvgen monitor.
> >
> > Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
>
> I am not entirely sure about this. In the future, when the generation
> output is changed, all the references files also need to be updated. So
> it's not clear to me if this really saves future development effort.
Yeah that's an issue with all this testing with golden files. At least unless we
change the output drastically, changes to those should be easy to apply and to
review (and LLMs can help here too).
> But well, we will see. For now:
>
> Reviewed-by: Nam Cao <namcao@linutronix.de>
Thanks,
Gabriele
next prev parent reply other threads:[~2026-07-09 15:52 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 12:14 [PATCH v3 00/17] rv: Add selftests to tools and KUnit tests Gabriele Monaco
2026-06-25 12:14 ` [PATCH v3 01/17] rv: Use generic rv_this for the rv_monitor variable in LTL Gabriele Monaco
2026-07-02 13:43 ` Nam Cao
2026-06-25 12:14 ` [PATCH v3 02/17] tools/rv: Fix exit status when monitor execution fails Gabriele Monaco
2026-06-25 12:14 ` [PATCH v3 03/17] verification/rvgen: Improve rv_dir discovery in RVGenerator Gabriele Monaco
2026-07-02 13:53 ` Nam Cao
2026-07-02 14:00 ` Thomas Weissschuh
2026-07-02 14:01 ` Gabriele Monaco
2026-07-02 14:09 ` Thomas Weissschuh
2026-07-02 14:16 ` Nam Cao
2026-06-25 12:14 ` [PATCH v3 04/17] tools/rv: Add selftests Gabriele Monaco
2026-06-28 17:10 ` Wen Yang
2026-06-29 6:51 ` Gabriele Monaco
2026-06-25 12:14 ` [PATCH v3 05/17] verification/rvgen: Add golden and spec folders for tests Gabriele Monaco
2026-06-25 12:14 ` [PATCH v3 06/17] verification/rvgen: Add selftests Gabriele Monaco
2026-07-09 17:13 ` Wen Yang
2026-06-25 12:14 ` [PATCH v3 07/17] rv: Add KUnit stub to rv_react() and rv_*_task_monitor_slot() Gabriele Monaco
2026-07-02 13:59 ` Nam Cao
2026-06-25 12:14 ` [PATCH v3 08/17] rv: Export task monitor slot and react symbols Gabriele Monaco
2026-07-02 14:00 ` Nam Cao
2026-06-25 12:14 ` [PATCH v3 09/17] rv: Add KUnit tests for some DA/HA monitors Gabriele Monaco
2026-07-07 6:52 ` Nam Cao
2026-06-25 12:14 ` [PATCH v3 10/17] rv: Add KUnit stub for current Gabriele Monaco
2026-06-25 12:14 ` [PATCH v3 11/17] rv: Prevent unintentional tracepoints during KUnit tests Gabriele Monaco
2026-06-28 17:17 ` Wen Yang
2026-07-07 7:00 ` Nam Cao
2026-07-07 7:23 ` Gabriele Monaco
2026-06-25 12:14 ` [PATCH v3 12/17] rv: Add KUnit tests for some LTL monitors Gabriele Monaco
2026-07-07 7:04 ` Nam Cao
2026-06-25 12:14 ` [PATCH v3 13/17] verification/rvgen: Add the rvgen kunit subcommand Gabriele Monaco
2026-07-09 8:02 ` Nam Cao
2026-06-25 12:14 ` [PATCH v3 14/17] verification/rvgen: Add selftests for rvgen kunit Gabriele Monaco
2026-06-28 17:06 ` Wen Yang
2026-06-29 7:04 ` Gabriele Monaco
2026-07-09 8:11 ` Nam Cao
2026-07-09 15:52 ` Gabriele Monaco [this message]
2026-06-25 12:14 ` [PATCH v3 15/17] selftests/verification: Fix wrong errexit assumption Gabriele Monaco
2026-07-09 8:14 ` Nam Cao
2026-07-09 17:10 ` Wen Yang
2026-06-25 12:14 ` [PATCH v3 16/17] selftests/verification: Rearrange the wwnr_printk test Gabriele Monaco
2026-07-09 17:08 ` Wen Yang
2026-07-10 8:31 ` Gabriele Monaco
2026-07-10 6:18 ` Nam Cao
2026-07-10 8:41 ` Gabriele Monaco
2026-06-25 12:14 ` [PATCH v3 17/17] selftests/verification: Add selftests for deadline and stall monitors Gabriele Monaco
2026-06-28 16:58 ` Wen Yang
2026-07-02 14:05 ` Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b50ff177c4ddd4521627cabd67ed9df638f850ed.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox