From: Crystal Wood <crwood@redhat.com>
To: Costa Shulyupin <costa.shul@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tomas Glozar <tglozar@redhat.com>,
Wander Lairson Costa <wander@redhat.com>,
Ivan Pravdin <ipravdin.official@gmail.com>,
linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] tools/rtla: Fix --dump-task option name to --dump-tasks
Date: Tue, 14 Apr 2026 13:07:12 -0500 [thread overview]
Message-ID: <e5d69985fbdcacbcb47a1643dee0036ec93c3a06.camel@redhat.com> (raw)
In-Reply-To: <20260414140621.28027-1-costa.shul@redhat.com>
On Tue, 2026-04-14 at 17:06 +0300, Costa Shulyupin wrote:
> The option was inconsistently named --dump-task in the usage
> string and getopt_long table while the actual implementation
> uses --dump-tasks. Fix both occurrences to match.
How is the getopt_long table not the "actual implementation"?
Wouldn't it make more sense to fix the one place in the documentation
that says --dump-tasks to match what the current behavior is?
...except that apparently timerlat top does use --dump-tasks[1], so
maybe we want to make that consistent, but the changelog should be clear
that this is an interface change for timerlat hist.
We should also probably be making sure we have test coverage for both
hist and top, which would have caught this, rather than picking one or
the other for most tests.
-Crystal
[1] Oddly, timerlat_top.c is missing --dump-tasks from msg_start[],
which is the one place that timerlat_hist.c has the plural --dump-tasks.
next prev parent reply other threads:[~2026-04-14 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 14:06 [PATCH v1] tools/rtla: Fix --dump-task option name to --dump-tasks Costa Shulyupin
2026-04-14 18:07 ` Crystal Wood [this message]
2026-04-14 18:51 ` Costa Shulyupin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d69985fbdcacbcb47a1643dee0036ec93c3a06.camel@redhat.com \
--to=crwood@redhat.com \
--cc=costa.shul@redhat.com \
--cc=ipravdin.official@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox