Re: [PATCH v7 02/10] riscv: Add KUnit test for stack trace start frames

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] riscv: vmlinux link failure when CONFIG_KUNIT=m with
  RISCV_STACKTRACE_KUNIT_TEST
--

commit 88e1ac2e959d970cabee9d276d02925cc3d44f40
Author: Karl Mehltretter <kmehltretter@gmail.com>

riscv: Add KUnit test for stack trace start frames

This commit adds a KUnit test suite to verify the starting frame and skip
counts of stack_trace_save() and ftrace_return_address() on RISC-V.

Link: https://lore.kernel.org/r/20261010132712.46931-2-kmehltretter@gmail.com

> diff --git a/arch/riscv/kernel/tests/Kconfig.debug b/arch/riscv/kernel/tests/Kconfig.debug
> index 40f8dafffa0ab..eb79df5b2c5a4 100644
> --- a/arch/riscv/kernel/tests/Kconfig.debug
> +++ b/arch/riscv/kernel/tests/Kconfig.debug
> @@ -42,6 +42,18 @@ config RISCV_KPROBES_KUNIT
>  
>           If unsure, say N.
>  
> +config RISCV_STACKTRACE_KUNIT_TEST
> +	bool "KUnit tests for RISC-V stack trace start frames"
> +	depends on KUNIT && STACKTRACE && FRAME_POINTER && KALLSYMS

[Severity: Medium]
Does declaring RISCV_STACKTRACE_KUNIT_TEST as bool while depending on
tristate KUNIT break the vmlinux link when CONFIG_KUNIT=m and
CONFIG_RISCV_STACKTRACE_KUNIT_TEST=y (such as under allmodconfig)?

In that configuration, stacktrace_test.o is built into vmlinux while the
KUnit core symbols it calls (__kunit_do_failed_assertion, kunit_log_append,
etc.) live in kunit.ko, similar to the issue fixed for RISCV_KPROBES_KUNIT
in 5fada1605733 ("riscv: tests: Make RISCV_KPROBES_KUNIT tristate").

Should this depend on KUNIT=y instead (since building stacktrace_test as a
module would also cause sprint_symbol_no_offset() in
riscv_stacktrace_check_skip() and riscv_return_address_check() to append
" [stacktrace_test]" to the symbol names)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110013750.36800-1-xueshuai@linux.alibaba.com?part=2