* [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
@ 2026-11-16 22:46 Brian Norris
2026-11-16 22:58 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2026-11-16 22:46 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu
Cc: linux-kernel, linux-trace-kernel, Mathieu Desnoyers, Brian Norris
GENERIC_TRACER is not a user-selectable symbol, so it's impossible to
enable FTRACE_STARTUP_TEST unless one also enables some other symbol
that 'selects' GENERIC_TRACER for us.
This very file also suggests:
All tracer options should select GENERIC_TRACER
So, use 'select', not 'depends on'.
Fixes: 60a11774b38f ("ftrace: add self-tests")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
kernel/trace/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 35d043b19332..8084d46ef2a0 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -1135,7 +1135,7 @@ config FTRACE_SELFTEST
config FTRACE_STARTUP_TEST
bool "Perform a startup test on ftrace"
- depends on GENERIC_TRACER
+ select GENERIC_TRACER
select FTRACE_SELFTEST
help
This option performs a series of startup tests on ftrace. On bootup
--
2.56.1.703.gf848ed807c-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
@ 2026-11-16 22:58 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-16 22:58 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-trace-kernel
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] tracing: FTRACE_STARTUP_TEST misuses select GENERIC_TRACER
- [Low] tracing: inaccurate Fixes trailer commit in commit message
--
commit 4d561c782a03c23e0e690cb6af78d98e81aa94d6
Author: Brian Norris <briannorris@chromium.org>
> tracing: 'select' GENERIC_TRACER, not 'depends'
>
> GENERIC_TRACER is not a user-selectable symbol, so it's impossible to
> enable FTRACE_STARTUP_TEST unless one also enables some other symbol
> that 'selects' GENERIC_TRACER for us.
>
> This very file also suggests:
>
> All tracer options should select GENERIC_TRACER
>
> So, use 'select', not 'depends on'.
>
> Fixes: 60a11774b38f ("ftrace: add self-tests")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
[Severity: Low]
Commit 60a11774b38f ("ftrace: add self-tests") added FTRACE_STARTUP_TEST
with "depends on TRACING" before GENERIC_TRACER existed. Should the Fixes
tag instead reference 5e0a09391087 ("tracing: fix config options to not
show when automatically selected"), which introduced GENERIC_TRACER and
changed FTRACE_STARTUP_TEST to depend on it?
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index c41397eccee50..347658dabbe33 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -1135,7 +1135,7 @@ config FTRACE_SELFTEST
>
> config FTRACE_STARTUP_TEST
> bool "Perform a startup test on ftrace"
> - depends on GENERIC_TRACER
> + select GENERIC_TRACER
> select FTRACE_SELFTEST
> help
> This option performs a series of startup tests on ftrace. On bootup
[Severity: Low]
Should FTRACE_STARTUP_TEST depend on TRACING (or select TRACING) instead
of selecting GENERIC_TRACER?
GENERIC_TRACER is meant only for full tracer options so that
ENABLE_DEFAULT_TRACERS is hidden when a full tracer is enabled:
kernel/trace/Kconfig:
# All tracer options should select GENERIC_TRACER. For those options that are
# enabled by all tracers (context switch and event tracer) they select TRACING.
...
config ENABLE_DEFAULT_TRACERS
bool "Trace process context switches and events"
depends on !GENERIC_TRACER
select TRACING
Because FTRACE_STARTUP_TEST is a test option rather than a tracer, having
it select GENERIC_TRACER disables and hides ENABLE_DEFAULT_TRACERS when no
full tracer is configured, and implicitly pulls in TRACING even when all
tracers are disabled.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116144652.1.Iecb63200dd245f62032a3b1f60ae78cc48868094@changeid?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-16 22:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
2026-11-16 22:58 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox