[uml-devel] compile problem iin 2.4.23 + 2.4.22-6

[uml-devel] compile problem iin 2.4.23 + 2.4.22-6

[Ross Combs]

During compilation I get the following error:

gcc -D__KERNEL__ -I/var/updates/linux-2.4.23/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -U__i386__ -Ui386 -DUM_FASTCALL  -D__arch_um__ -DSUBARCH="i386" -D_LARGEFILE64_SOURCE -I/var/updates/linux-2.4.23/arch/um/include -Derrno=kernel_errno -I/var/updates/linux-2.4.23/arch/um/kernel/tt/include -I/var/updates/linux-2.4.23/arch/um/kernel/skas/include   -nostdinc -iwithprefix include -DKBUILD_BASENAME=binfmt_elf  -c -o binfmt_elf.o binfmt_elf.c
binfmt_elf.c:806:44: macro "ELF_PLAT_INIT" passed 2 arguments, but takes just 1
make[2]: *** [binfmt_elf.o] Error 1
make[2]: Leaving directory `/var/updates/linux-2.4.23/fs'
make[1]: *** [first_rule] Error 2
make[1]: Leaving directory `/var/updates/linux-2.4.23/fs'
make: *** [_dir_fs] Error 2

It looks like every arch uses a macro like this:

 ELF_PLAT_INIT(_r, load_addr)

but uml defines it like this:

 ELF_PLAT_INIT(regs)

Has anyone updated the patch to 2.4.23 yet?  If not, I'll be backporting
the missing brk() range check from 2.4.23.

-Ross


-------------------------------------------------------
This SF.net email is sponsored by OSDN's Audience Survey.
Help shape OSDN's sites and tell us what you think. Take this
five minute survey and you could win a $250 Gift Certificate.
http://www.wrgsurveys.com/2003/osdntech03.php?site=8
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] compile problem iin 2.4.23 + 2.4.22-6

[Christopher S. Aker]

Hello Ross,

> It looks like every arch uses a macro like this:
>
>  ELF_PLAT_INIT(_r, load_addr)
>
> but uml defines it like this:
>
>  ELF_PLAT_INIT(regs)
>
> Has anyone updated the patch to 2.4.23 yet?  If not, I'll be backporting
> the missing brk() range check from 2.4.23.

Change "include/asm-um/archparam.h" to read

#define ELF_PLAT_INIT(regs, load_addr) do { \

There is a very good chance this isn't correct (/me is not a kernel hacker), but
I've been running the kernel since yesterday and so far so good.

-Chris




-------------------------------------------------------
This SF.net email is sponsored by OSDN's Audience Survey.
Help shape OSDN's sites and tell us what you think. Take this
five minute survey and you could win a $250 Gift Certificate.
http://www.wrgsurveys.com/2003/osdntech03.php?site=8
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] compile problem iin 2.4.23 + 2.4.22-6

[Ross Combs]

"Christopher S. Aker" <caker@theshore.net> wrote:

> Hello Ross,
>
> > It looks like every arch uses a macro like this:
> >
> >  ELF_PLAT_INIT(_r, load_addr)
> >
> > but uml defines it like this:
> >
> >  ELF_PLAT_INIT(regs)
> >
> > Has anyone updated the patch to 2.4.23 yet?  If not, I'll be backporting
> > the missing brk() range check from 2.4.23.
>
> Change "include/asm-um/archparam.h" to read
>
> #define ELF_PLAT_INIT(regs, load_addr) do { \
>
> There is a very good chance this isn't correct (/me is not a kernel hacker), but
> I've been running the kernel since yesterday and so far so good.

That's working perfectly here as well.  I didn't realize the macro was so
simple.  The second parameter is unused and all it does is initialize the
registers to zero on i386.

Thanks for your help.

-Ross


-------------------------------------------------------
This SF.net email is sponsored by OSDN's Audience Survey.
Help shape OSDN's sites and tell us what you think. Take this
five minute survey and you could win a $250 Gift Certificate.
http://www.wrgsurveys.com/2003/osdntech03.php?site=8
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel