linux-um archives
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: anton ivanov <anton.ivanov@cambridgegreys.com>
Cc: linux-um <linux-um@lists.infradead.org>,
	 Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH v5] um: Enable preemption in UML
Date: Fri, 22 Sep 2023 09:27:23 +0200 (CEST)	[thread overview]
Message-ID: <1938743835.68560.1695367643504.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20230922065212.484385-1-anton.ivanov@cambridgegreys.com>

----- Ursprüngliche Mail -----
> Von: "anton ivanov" <anton.ivanov@cambridgegreys.com>
> An: "linux-um" <linux-um@lists.infradead.org>
> CC: "Johannes Berg" <johannes@sipsolutions.net>, "richard" <richard@nod.at>, "anton ivanov"
> <anton.ivanov@cambridgegreys.com>
> Gesendet: Freitag, 22. September 2023 08:52:12
> Betreff: [PATCH v5] um: Enable preemption in UML

> From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> 
> Preemption requires saving/restoring FPU state. This patch
> adds support for it using GCC intrinsics.

Can you please state in future patches what you have changed since the last one?
 
> Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> diff --git a/arch/um/kernel/tlb.c b/arch/um/kernel/tlb.c
> index 7d050ab0f78a..34ec8e677fb9 100644
> --- a/arch/um/kernel/tlb.c
> +++ b/arch/um/kernel/tlb.c
> @@ -362,6 +362,9 @@ static int flush_tlb_kernel_range_common(unsigned long
> start, unsigned long end)
> 
> 	mm = &init_mm;
> 	hvc = INIT_HVC(mm, force, userspace);
> +
> +    preempt_disable();
> +

Does this address the bootup splat I've reported yesterday?


Thanks,
//richard

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

  reply	other threads:[~2023-09-22  7:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22  6:52 [PATCH v5] um: Enable preemption in UML anton.ivanov
2023-09-22  7:27 ` Richard Weinberger [this message]
2023-09-22  7:29   ` Anton Ivanov
2023-09-22  7:30 ` Johannes Berg
2023-09-22  7:38   ` Anton Ivanov
2023-09-22  7:40     ` Johannes Berg
2023-09-22  8:01       ` Anton Ivanov
2023-09-22  8:13         ` Johannes Berg
2023-09-22  8:40           ` Anton Ivanov
2023-09-22  8:41           ` Johannes Berg
2023-09-22  8:43             ` Johannes Berg
2023-09-22  9:04               ` Johannes Berg
2023-09-22  9:12                 ` Anton Ivanov
2023-09-22  9:06             ` Anton Ivanov
2023-09-22  9:10               ` Johannes Berg
2023-09-22  9:14                 ` Johannes Berg
2023-09-22  9:19                   ` Anton Ivanov
2023-09-22  9:51                     ` Johannes Berg
2023-09-22  9:55                       ` Johannes Berg
2023-09-22 10:55                         ` Anton Ivanov
2023-09-22 11:17                           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1938743835.68560.1695367643504.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-um@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox