From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Johannes Berg <johannes@sipsolutions.net>, linux-um@lists.infradead.org
Cc: richard@nod.at
Subject: Re: [PATCH v5] um: Enable preemption in UML
Date: Fri, 22 Sep 2023 10:06:23 +0100 [thread overview]
Message-ID: <40babfb4-ed65-dd0e-23aa-abdfaa9c7149@cambridgegreys.com> (raw)
In-Reply-To: <210bd25b2dcd9e4424923f55053086f67e219cc4.camel@sipsolutions.net>
On 22/09/2023 09:41, Johannes Berg wrote:
>> Yes, but when does the fork actually happen?
>>
> Looking further at this, now I'm confused as to why it doesn't happen
> _all_ the time.
>
> I think this has pretty much always been wrong, just now we actually
> notice it?
>
> Basically, when we create a new thread (really just mm I think), we say
> the first thing that has to run there is fork_handler(), which
> initialises things the first time around. This calls force_flush_all()
>
> But of course it's called from __schedule(), which has
> preemption/interrupts disabled. So you can't do mmap_read_lock()?
Stupid question.
If we have preemption and interrupts disabled and we are UP do we really need to lock it at this point?
>
> But I'm confused as to why it doesn't seem happen all the time?
>
> johannes
>
> _______________________________________________
> linux-um mailing list
> linux-um@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-um
>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2023-09-22 9:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 6:52 [PATCH v5] um: Enable preemption in UML anton.ivanov
2023-09-22 7:27 ` Richard Weinberger
2023-09-22 7:29 ` Anton Ivanov
2023-09-22 7:30 ` Johannes Berg
2023-09-22 7:38 ` Anton Ivanov
2023-09-22 7:40 ` Johannes Berg
2023-09-22 8:01 ` Anton Ivanov
2023-09-22 8:13 ` Johannes Berg
2023-09-22 8:40 ` Anton Ivanov
2023-09-22 8:41 ` Johannes Berg
2023-09-22 8:43 ` Johannes Berg
2023-09-22 9:04 ` Johannes Berg
2023-09-22 9:12 ` Anton Ivanov
2023-09-22 9:06 ` Anton Ivanov [this message]
2023-09-22 9:10 ` Johannes Berg
2023-09-22 9:14 ` Johannes Berg
2023-09-22 9:19 ` Anton Ivanov
2023-09-22 9:51 ` Johannes Berg
2023-09-22 9:55 ` Johannes Berg
2023-09-22 10:55 ` Anton Ivanov
2023-09-22 11:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40babfb4-ed65-dd0e-23aa-abdfaa9c7149@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=johannes@sipsolutions.net \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox