[uml-devel] cleanup file io

[uml-devel] cleanup file io

[Steve Schmidtke]

Hi Jeff,

Can I submit a cleanup patch that does stuff like this all over UML:

int load_initrd(char *filename, void *buf, int size)
{
        int fd, n;

        if((fd = os_open_file(filename, of_read(OPENFLAGS()), 0)) < 0){
-               printk("Opening '%s' failed - errno = %d\n", filename, 
errno);
+               printk("Opening '%s' failed - err = %d\n", filename, fd);
                return(-1);
        }
-       if((n = read(fd, buf, size)) != size){
+       if((n = os_read_file(fd, buf, size)) != size){
                printk("Read of %d bytes from '%s' returned %d, errno = 
%d\n",
                       size, filename, n, errno);
                return(-1);
        }
        return(0);
}

i.e. wrap bare file functions into their os_* counterparts, and remove 
unnecessary references to errno?

Also, is there a style reason some functions like the one above return -1 
rather than -errno or the failed (negative) return value from the os_* 
functions?  I'd like to standardize one style or the other while I'm at it, 
if that's workable.

Thanks,

Steve Schmidtke

_________________________________________________________________
Add photos to your e-mail with MSN 8. Get 2 months FREE*.  
http://join.msn.com/?page=features/featuredemail



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

[uml-devel] Re: cleanup file io

[Jeff Dike]

steve_schmidtke@hotmail.com said:
> i.e. wrap bare file functions into their os_* counterparts, and remove
>  unnecessary references to errno? 

I'd love such a patch.

> Also, is there a style reason some functions like the one above return
> -1  rather than -errno or the failed (negative) return value from the
> os_*  functions?  I'd like to standardize one style or the other while
> I'm at it,  if that's workable. 

I'd like to stick to the convention that success == 0, failure == -errno.
I just fixed a bug with os_seek_file that resulted from a misunderstanding
between me and myself on that issue.

				Jeff


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel