[uml-devel] Re: [PATCH] mconsole fixes

[Jeff Dike <jdike@addtoit.com>]

dan@shearer.org said:
> + * instance over a local pipe connection. This tool does not 
> + * (since uml_mconsole version 1) need to be in sync with the version
> + * of the UML kernel since the commands and their implementation 
> + * are within UML.

The version does need to match.  UML will only talk to one version of mconsole.

The smarts are all in the kernel, but they do need to agree on the format of
the request and the response.

> -    fprintf(stderr, "Sending command to '%s' : ", sun.sun_path);
> -    perror("");
> -    return;
> +    if (strlen(sun.sun_path)==0) {
> +      fprintf(stderr, "No connection exists, cannot send command.\n");
> +    } else {
> +      fprintf(stderr, "While sending command to '%s' : ", sun.sun_path);
> +      perror("");
> +    }
> +    return(1);

I don't see the point of the strlen(sun.sun_path)==0 check, so I'm leaving that
out until I see why it's necessary.

I applied most of the rest of that.  I got rid of the exits from main, since
I like returns better and I tidied up some other stuff.

				Jeff



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel