Re: [uml-devel] Re: [PATCH] mconsole fixes

[Dan Shearer <dan@shearer.org>]

On Tue, Jan 27, 2004 at 08:46:36PM -0500, Jeff Dike wrote:
 
> > -    fprintf(stderr, "Sending command to '%s' : ", sun.sun_path);
> > -    perror("");
> > -    return;
> > +    if (strlen(sun.sun_path)==0) {
> > +      fprintf(stderr, "No connection exists, cannot send command.\n");
> > +    } else {
> > +      fprintf(stderr, "While sending command to '%s' : ", sun.sun_path);
> > +      perror("");
> > +    }
> > +    return(1);
> 
> I don't see the point of the strlen(sun.sun_path)==0 check, so I'm
> leaving that out until I see why it's necessary.

My idea was that there's a difference between an error on a connection
and no connection at all. Having no connection at all can happen very
easily, especially if you happen to use uml_dir on the cmdline which
triggers a bug that puts the file in the wrong place.

> I applied most of the rest of that.  I got rid of the exits from main, since
> I like returns better and I tidied up some other stuff.

Minor portability potential. See
http://www.eskimo.com/~scs/C-faq/q11.16.html. (I looked it up once long
ago and supposedly _exit is more likely to work on more systems than
exit.)

-- 
Dan Shearer
dan@shearer.org


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel