Re: [uml-devel] [PATCH] nptl/sys_clone fix for i386/ppc

[BlaisorBlade <blaisorblade_spam@yahoo.it>]

Alle 04:06, giovedì 26 agosto 2004, David Jeffery ha scritto:
> This is a patch against 2.6.8.1-mm4 to fix a skas UML problem with a
> nptl glibc.

> UML with an nptl enabled glibc causes process creation to fail with
> this assertion failure in nptl:

I have just one problem in understanding you: are you talking about:
- linking the Uml binary against a NPTL glibc,
or
- using NPTL inside the Uml virtual machine?
From the actual patch, it seems that you are doing the second thing, but 
nobody has been able, so far, to use NPTL *inside* UML, and we all thought 
that since UML misses the new NPTL syscalls, that was the reason. If this 
patch, instead, was enough for you, I'm very happy.

> The problem is caused by the incorrect implementation of sys_clone().
> sys_clone() is an ugly beast that has different arguements depending on
> the architecture.  For i386 and ppc, the child tid is passed as the
> 5th arguement instead of as the 4th arguement as as some other
> architectures (like x86-64) do.  The 4th arguement on i386 and ppc
> doesn't look to be used by the kernel.
Ok, it seems reasonable.
> With this patch I've been running several UML skas images with a Debian
> Sarge based systems for several days without problem.  The patch adds a
> sys_clone_5arg() on i386 and ppc which just raps around the current
> sys_clone() so the child tid pointer in the 5th arguement will be passed
> down correctly.  I don't get any style points for this patch so feel
> free to pretty it up.


> diff -urN linux-2.6.8.1-mm4.orig/arch/um/Makefile
> linux-2.6.8.1-mm4/arch/um/Makefile ---
> linux-2.6.8.1-mm4.orig/arch/um/Makefile	2004-08-25 20:52:56.000000000 -0400
> +++ linux-2.6.8.1-mm4/arch/um/Makefile	2004-08-22 16:55:52.000000000 -0400
> @@ -59,7 +59,8 @@
>
>  CFLAGS += $(CFLAGS-y) -D__arch_um__ -DSUBARCH=\"$(SUBARCH)\" \
>  	-D_LARGEFILE64_SOURCE $(ARCH_INCLUDE) -Derrno=kernel_errno \
> -	-Dsigprocmask=kernel_sigprocmask $(MODE_INCLUDE)
> +	-Dsigprocmask=kernel_sigprocmask $(MODE_INCLUDE) \
> +	-D__subarch_$(SUBARCH)__

Isn't enough the -DSUBARCH= ?
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idP47&alloc_id\x10808&opÌk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel