Re: [uml-devel] [PATCH] nptl/sys_clone fix for i386/ppc

[BlaisorBlade <blaisorblade_spam@yahoo.it>]

On Saturday 11 September 2004 01:52, Jeff Dike wrote:
> djeffery@britsys.net said:
> > The problem is caused by the incorrect implementation of sys_clone().
> >  sys_clone() is an ugly beast that has different arguements depending
> > on  the architecture.  For i386 and ppc, the child tid is passed as
> > the  5th arguement instead of as the 4th arguement as as some other
> > architectures (like x86-64) do.  The 4th arguement on i386 and ppc
> > doesn't look to be used by the kernel.
>
> This is fixed in my tree.  It was a lot simpler than your patch, or what I
> led you to believe.  I just moved sys_clone from syscall_kern.c to
> arch/um/sys-i386/syscalls.c and fixed the interface.

Jeff, please fix your patch again - the unused argument is the fourth, not the 
third:

original one
+#if defined(__subarch_i386__) || defined(__subarch_ppc__)
+long sys_clone_5arg(unsigned long clone_flags, unsigned long newsp,
+               int *parent_tid, unsigned long unused, int *child_tid)
+{
+        return sys_clone(clone_flags, newsp, parent_tid, child_tid);
+}
+#endif

Also, Andrew Morton wrote some UML fixes (for scheduler bugs) on his own. Did 
you already note this or you want them forwarded?
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel