[uml-devel] Re: [patch 1/1] uml: fail xterm_open when we have no $DISPLAY

[uml-devel] Re: [patch 1/1] uml: fail xterm_open when we have no $DISPLAY

[Blaisorblade]

On Tuesday 07 December 2004 05:55, blaisorblade_spam@yahoo.it wrote:
> From: Chris Wedgwood <cw@f00f.org>
Gerd, I've sent this to you since you've been working on the terminal-cleanup. 
You might as well get some ideas from this one - and it or some cleaned-up 
version will be merged for 2.6.11.

Bye

P.S.: I've not yet got an answer about your general-protection-fault patch and 
the issues I raised up. What about that?

> If UML wants to open an xterm channel and the xterm does not run properly
> (eg. terminates soon after starting) we will get a hang (a comment added in
> the patch explains why).
>
> This avoids the most common cause for this and adds a comment (which long
> term will go away with a rewrite of that code); the complete fix would be
> to catch the xterm process dying, up(&data->sem), and -EIO all requests
> from that point onwards.
>
> That applies for some of the other channels too, so part of the code should
> probably be abstracted a little and generalized.
>
> Signed-off-by: Chris Wedgwood <cw@f00f.org>
> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it>
> (modified) Signed-off-by: Paolo 'Blaisorblade' Giarrusso
> <blaisorblade_spam@yahoo.it> ---


-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel