From: Blaisorblade <blaisorblade_spam@yahoo.it>
To: bstroesser@fujitsu-siemens.com
Cc: jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: [patch 1/1] make arch/um/kernel/skas/include/skas.h include asm/types.h
Date: Fri, 10 Dec 2004 22:28:07 +0100 [thread overview]
Message-ID: <200412102228.07984.blaisorblade_spam@yahoo.it> (raw)
In-Reply-To: <200412101645.iBAGjWA13367@trolli.pdb.fsc.net>
On Friday 10 December 2004 17:45, bstroesser@fujitsu-siemens.com wrote:
> From: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
>
> make arch/um/kernel/skas/include/skas.h include asm/types.h
> This is necessary to have a typedef for __u64
*Probably* won't work, as headers in arch/um/include.... are also includable
by userspace files, which can't include <asm/types.h>; well, it could happen
to include the *host* asm/types.h, which will be bad on a x86_64 host, since
you could get a "unsigned long" (which is safe) even when compiling a 32-bit
UML!
Otherwise, there would not be includes in arch/um! They'd be in
include/asm-um!
And yes, this sucks, but is reality.
Workaround it - unsigned long long is always a correct definition.
> Signed-off-by: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
> ---
>
>
> diff -puN arch/um/kernel/skas/include/skas.h~skas.h-include-types.h
> arch/um/kernel/skas/include/skas.h ---
> linux-2.6.10-rc2-mm4/arch/um/kernel/skas/include/skas.h~skas.h-include-type
>s.h 2004-12-10 15:53:03.726530054 +0100 +++
> linux-2.6.10-rc2-mm4-root/arch/um/kernel/skas/include/skas.h 2004-12-10
> 15:53:03.730528661 +0100 @@ -7,6 +7,7 @@
> #define __SKAS_H
>
> #include "sysdep/ptrace.h"
> +#include "asm/types.h"
>
> extern int userspace_pid[];
>
> _
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2004-12-10 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-10 16:45 [uml-devel] [patch 1/1] make arch/um/kernel/skas/include/skas.h include asm/types.h bstroesser
2004-12-10 21:28 ` Blaisorblade [this message]
2004-12-13 13:00 ` [uml-devel] " Bodo Stroesser
2004-12-16 18:24 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412102228.07984.blaisorblade_spam@yahoo.it \
--to=blaisorblade_spam@yahoo.it \
--cc=bstroesser@fujitsu-siemens.com \
--cc=jdike@addtoit.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox