[uml-devel] Re: [patch 1/1] make arch/um/kernel/skas/include/skas.h include asm/types.h

[Blaisorblade <blaisorblade_spam@yahoo.it>]

On Monday 13 December 2004 14:00, Bodo Stroesser wrote:
> Blaisorblade wrote:
> > On Friday 10 December 2004 17:45, bstroesser@fujitsu-siemens.com wrote:
> >>From: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
> >>
> >>make arch/um/kernel/skas/include/skas.h include asm/types.h
> >>This is necessary to have a typedef for __u64
> >
> > *Probably* won't work, as headers in arch/um/include.... are also
> > includable by userspace files, which can't include <asm/types.h>;
>
> My patch changes arch/um/kernel/skas/include/skas.h, which is included by
> arch/um/kernel/process.c
in arch/um/kernel/Makefile, USER_OBJS lists it.
> , arch/um/sys-XXXX/signal.c
> and some  
> arch/um/kernel/skas/XXXX.c. IMHO, this should be safe, or do I miss
> somesthing?
Not exactly. The reference is the USER_OBJS content for those makefiles. An 
_user file is always for userspace, a _kern one for kernelspace, for others 
no fixed rule from the name.

> well, it could happen
>
> > to include the *host* asm/types.h, which will be bad on a x86_64 host,
> > since you could get a "unsigned long" (which is safe) even when compiling
> > a 32-bit UML!
> >
> > Otherwise, there would not be includes in arch/um! They'd be in
> > include/asm-um!
> >
> > And yes, this sucks, but is reality.
> >
> > Workaround it - unsigned long long is always a correct definition.
>
> This would be another possibility, but then the definition of "void map()"
> in arch/um/kernel/skas/mem_user.c also should be changed.
Yes, I agree...
> I choosed the 
> option, which changes less. Feel free to choose the other one.

-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel