[uml-devel] Breakage of compilation in .11-rc1 - "code-tidying" is broken

[uml-devel] Breakage of compilation in .11-rc1 - "code-tidying" is broken

[Blaisorblade]

I've verified the compilation problem posted about -rc1:

arch/um/kernel/process.c: In function `check_ptrace':
arch/um/kernel/process.c:321: error: `PTRACE_SETOPTIONS' undeclared (first use 
in this function)
arch/um/kernel/process.c:321: error: (Each undeclared identifier is reported 
only once
arch/um/kernel/process.c:321: error: for each function it appears in.)
arch/um/kernel/process.c:321: error: `PTRACE_O_TRACESYSGOOD' undeclared (first 
use in this function)

This is related to the TRACESYSGOOD patch and to an unverified patch, i.e. :

http://linux.bkbits.net:8080/linux-2.5/cset@41e49628dGbOWX-bT9yZII4f19GT6A

I.e, the "Code Tidying" patch still on the incrementals.

In fact, including both linux/ptrace.h and sys/ptrace.h is not redundant - it 
must also be done in the proper order, so I'm writing a patch with the 
appropriate content.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Re: Breakage of compilation in .11-rc1 - "code-tidying" is broken

[Blaisorblade]

On Thursday 13 January 2005 23:05, Jeff Dike wrote:
> blaisorblade@yahoo.it said:
> > In fact, including both linux/ptrace.h and sys/ptrace.h is not
> > redundant - it  must also be done in the proper order, so I'm writing
> > a patch with the  appropriate content.

> Wait till I update my patch list before fixing this.  Bodo send me a patch,
> which I am polishing now.

>     Jeff
I'm testing the compilation now - also, I'm commenting out part of the new 
syscalls - the vperfctr ones give problems, I guess they are mm-only for now.
Instead the key managing ones already exist.

So, I've done a patch for both things and I'm posting it - preserve the 
comment I added about those headers in your polished version which you'll 
merge.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

[uml-devel] Re: Breakage of compilation in .11-rc1 - "code-tidying" is broken

[Jeff Dike]

blaisorblade@yahoo.it said:
> In fact, including both linux/ptrace.h and sys/ptrace.h is not
> redundant - it  must also be done in the proper order, so I'm writing
> a patch with the  appropriate content. 

Wait till I update my patch list before fixing this.  Bodo send me a patch,
which I am polishing now.

				Jeff



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel