linux-um archives
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: Blaisorblade <blaisorblade@yahoo.it>
Subject: Re: [uml-devel] Hostfs permission checks are all wonky.
Date: Wed, 23 Mar 2005 03:13:04 -0500	[thread overview]
Message-ID: <200503230313.06299.rob@landley.net> (raw)
In-Reply-To: <200503222019.10709.blaisorblade@yahoo.it>

On Tuesday 22 March 2005 02:19 pm, Blaisorblade wrote:

> Ok, I'm now seeing that UML uses access() (inside access_file()) to check
> permissions.
>
> See hostfs_permission -> access_file -> access. hostfs_permission (not
> access_file) should skip the "access_file" call in case its type is
> OS_TYPE_CHARDEV / OS_TYPE_BLOCKDEV / OS_TYPE_FIFO / OS_TYPE_SOCK.
>
> Look at init_inode() about how to see the file's type, but even better look
> at the cached information, i.e. inode->i_mode and the S_* access macro
> (look at init_special_inode about this).

Just confirming: this patch fixed it.  Both /dev/loop0 and /dev/console work 
just fine with hostfs root now.

Can this patch make it into 2.6.12?

Rob


-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  parent reply	other threads:[~2005-03-23  9:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-20 19:17 [uml-devel] Hostfs permission checks are all wonky Rob Landley
2005-03-22 19:19 ` Blaisorblade
2005-03-23  6:09   ` Rob Landley
2005-03-24 10:53     ` Blaisorblade
2005-03-28 17:23       ` Rob Landley
2005-03-28 19:48       ` Rob Landley
2005-04-29 20:53         ` Blaisorblade
2005-04-28 23:45           ` Rob Landley
2005-03-23  8:13   ` Rob Landley [this message]
2005-03-24  2:02     ` Blaisorblade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503230313.06299.rob@landley.net \
    --to=rob@landley.net \
    --cc=blaisorblade@yahoo.it \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox