Re: [uml-devel] Hostfs permission checks are all wonky.

[Blaisorblade <blaisorblade@yahoo.it>]

On Wednesday 23 March 2005 09:13, Rob Landley wrote:
> On Tuesday 22 March 2005 02:19 pm, Blaisorblade wrote:
> > Ok, I'm now seeing that UML uses access() (inside access_file()) to check
> > permissions.
> >
> > See hostfs_permission -> access_file -> access. hostfs_permission (not
> > access_file) should skip the "access_file" call in case its type is
> > OS_TYPE_CHARDEV / OS_TYPE_BLOCKDEV / OS_TYPE_FIFO / OS_TYPE_SOCK.
> >
> > Look at init_inode() about how to see the file's type, but even better
> > look at the cached information, i.e. inode->i_mode and the S_* access
> > macro (look at init_special_inode about this).
>
> Just confirming: this patch fixed it.  Both /dev/loop0 and /dev/console
> work just fine with hostfs root now.
>
> Can this patch make it into 2.6.12?
Yes, it's on his way (in next group of merges however).
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade




-------------------------------------------------------
This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005
Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows
Embedded(r) & Windows Mobile(tm) platforms, applications & content.  Register
by 3/29 & save $300 http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel