[uml-devel] [PATCH 3/7] UML - Turn off kmalloc always on a fatal signal

[uml-devel] [PATCH 3/7] UML - Turn off kmalloc always on a fatal signal

[Jeff Dike]

We should turn off kmalloc when getting a fatal signal regardless of the
mode we're in.

Signed-off-by: Jeff Dike <jdike@addtoit.com>

Index: linux-2.6.11/arch/um/kernel/main.c
===================================================================
--- linux-2.6.11.orig/arch/um/kernel/main.c	2005-05-26 16:51:14.000000000 -0400
+++ linux-2.6.11/arch/um/kernel/main.c	2005-05-26 17:05:40.000000000 -0400
@@ -71,7 +71,7 @@ static __init void do_uml_initcalls(void
 
 static void last_ditch_exit(int sig)
 {
-	CHOOSE_MODE(kmalloc_ok = 0, (void) 0);
+        kmalloc_ok = 0;
 	signal(SIGINT, SIG_DFL);
 	signal(SIGTERM, SIG_DFL);
 	signal(SIGHUP, SIG_DFL);



-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH 3/7] UML - Turn off kmalloc always on a fatal signal

[Adam Heath]

On Thu, 26 May 2005, Jeff Dike wrote:

> We should turn off kmalloc when getting a fatal signal regardless of the
> mode we're in.
>
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>
> Index: linux-2.6.11/arch/um/kernel/main.c
> ===================================================================
> --- linux-2.6.11.orig/arch/um/kernel/main.c	2005-05-26 16:51:14.000000000 -0400
> +++ linux-2.6.11/arch/um/kernel/main.c	2005-05-26 17:05:40.000000000 -0400
> @@ -71,7 +71,7 @@ static __init void do_uml_initcalls(void
>
>  static void last_ditch_exit(int sig)
>  {
> -	CHOOSE_MODE(kmalloc_ok = 0, (void) 0);
> +        kmalloc_ok = 0;
>  	signal(SIGINT, SIG_DFL);
>  	signal(SIGTERM, SIG_DFL);
>  	signal(SIGHUP, SIG_DFL);

This and some of the other patches are changing the formatting.  The new line
above is using spaces instead of a tab.


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH 3/7] UML - Turn off kmalloc always on a fatal signal

[Jeff Dike]

On Thu, May 26, 2005 at 06:13:02PM -0500, Adam Heath wrote:
> This and some of the other patches are changing the formatting.  The new line
> above is using spaces instead of a tab.

On purpose - I'm making UML more CodingStyle conformant, and doing it as I'm
modifying stuff anyway.  The alternative is a set of whitespace patches, 
which will gratuitously make a barrier across which patches need to be
hand-merged.

				Jeff


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH 3/7] UML - Turn off kmalloc always on a fatal signal

[Blaisorblade]

On Friday 27 May 2005 03:16, Jeff Dike wrote:
> On Thu, May 26, 2005 at 06:13:02PM -0500, Adam Heath wrote:
> > This and some of the other patches are changing the formatting.  The new
> > line above is using spaces instead of a tab.
>
> On purpose - I'm making UML more CodingStyle conformant, and doing it as
> I'm modifying stuff anyway.  The alternative is a set of whitespace
> patches, which will gratuitously make a barrier across which patches need
> to be hand-merged.
Yes but CodingStyle recommends tabs:

"Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation, and the above example is deliberately broken."

-- 
Paolo Giarrusso, aka Blaisorblade
Skype user "PaoloGiarrusso"
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it



-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel