linux-um archives
 help / color / mirror / Atom feed
From: domen@coderock.org
To: jdike@karaya.com
Cc: user-mode-linux-devel@lists.sourceforge.net, domen@coderock.org
Subject: [uml-devel] [patch 1/1] um: copy_from_user size fix in signal.c
Date: Mon, 20 Jun 2005 23:50:42 +0200	[thread overview]
Message-ID: <20050620215041.767887000@nd47.coderock.org> (raw)

[-- Attachment #1: size-arch_um_sys-i386_signal --]
[-- Type: text/plain, Size: 1355 bytes --]

From: Domen Puncer <domen@coderock.org>


Size of pointer doesn't seem right, but maybe my solution isn't
either (sig_size maybe?).


Signed-off-by: Domen Puncer <domen@coderock.org>

---
 signal.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: quilt/arch/um/sys-i386/signal.c
===================================================================
--- quilt.orig/arch/um/sys-i386/signal.c
+++ quilt/arch/um/sys-i386/signal.c
@@ -312,7 +312,7 @@ long sys_sigreturn(struct pt_regs regs)
 	unsigned long __user *extramask = frame->extramask;
 	int sig_size = (_NSIG_WORDS - 1) * sizeof(unsigned long);
 
-	if(copy_from_user(&set.sig[0], oldmask, sizeof(&set.sig[0])) ||
+	if(copy_from_user(&set.sig[0], oldmask, sizeof(set.sig[0])) ||
 	   copy_from_user(&set.sig[1], extramask, sig_size))
 		goto segfault;
 

--


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

             reply	other threads:[~2005-06-20 21:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-20 21:50 domen [this message]
2005-06-20 22:38 ` [uml-devel] [patch 1/1] um: copy_from_user size fix in signal.c Blaisorblade
2005-06-20 23:30   ` Domen Puncer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050620215041.767887000@nd47.coderock.org \
    --to=domen@coderock.org \
    --cc=jdike@karaya.com \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox