From: Blaisorblade <blaisorblade@yahoo.it>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: domen@coderock.org, jdike@karaya.com
Subject: Re: [uml-devel] [patch 1/1] um: copy_from_user size fix in signal.c
Date: Tue, 21 Jun 2005 00:38:23 +0200 [thread overview]
Message-ID: <200506210038.23729.blaisorblade@yahoo.it> (raw)
In-Reply-To: <20050620215041.767887000@nd47.coderock.org>
On Monday 20 June 2005 23:50, domen@coderock.org wrote:
> From: Domen Puncer <domen@coderock.org>
>
>
> Size of pointer doesn't seem right, but maybe my solution isn't
> either (sig_size maybe?).
Your patch had already been submitted by Jeff a couple of hours before this
mail. Thanks!
> Signed-off-by: Domen Puncer <domen@coderock.org>
>
> ---
> signal.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: quilt/arch/um/sys-i386/signal.c
> ===================================================================
> --- quilt.orig/arch/um/sys-i386/signal.c
> +++ quilt/arch/um/sys-i386/signal.c
> @@ -312,7 +312,7 @@ long sys_sigreturn(struct pt_regs regs)
> unsigned long __user *extramask = frame->extramask;
> int sig_size = (_NSIG_WORDS - 1) * sizeof(unsigned long);
>
> - if(copy_from_user(&set.sig[0], oldmask, sizeof(&set.sig[0])) ||
> + if(copy_from_user(&set.sig[0], oldmask, sizeof(set.sig[0])) ||
> copy_from_user(&set.sig[1], extramask, sig_size))
> goto segfault;
>
>
> --
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
> from IBM. Find simple to follow Roadmaps, straightforward articles,
> informative Webcasts and more! Get everything you need to get up to
> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
> _______________________________________________
> User-mode-linux-devel mailing list
> User-mode-linux-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2005-06-20 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 21:50 [uml-devel] [patch 1/1] um: copy_from_user size fix in signal.c domen
2005-06-20 22:38 ` Blaisorblade [this message]
2005-06-20 23:30 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506210038.23729.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=domen@coderock.org \
--cc=jdike@karaya.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox