linux-um archives
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] Re: "Sleeping in atomic section" with ubd aio patch
Date: Wed, 14 Sep 2005 17:18:08 -0400	[thread overview]
Message-ID: <20050914211808.GA11567@ccure.user-mode-linux.org> (raw)
In-Reply-To: <200509142200.39886.blaisorblade@yahoo.it>

On Wed, Sep 14, 2005 at 10:00:39PM +0200, Blaisorblade wrote:
> Assuming it can be done, it'd be ok.
> 
> However, why have we already dequeued the request?

It is easier than removing segments from the request and finally
dequeueing the request when it is finally empty.

> Looking for examples, via grep blkdev_dequeue_request drivers/ide/*.c and 
> going opening drivers/ide/ide-io.c, I found blkdev_dequeue_request() called 
> *after* end_that_request_first(), while there it's called before.
> 
> A comment in blk_start_pre_flush() says there's some freedom, but probably 
> leaving the request in the queue would be ok....

There is a good amount of freedom.  The driver is given a set of
requests, and has the job of making them happen.

				Jeff


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2005-09-14 21:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-13 18:01 [uml-devel] "Sleeping in atomic section" with ubd aio patch Blaisorblade
2005-09-14 19:22 ` [uml-devel] " Jeff Dike
2005-09-14 20:00   ` Blaisorblade
2005-09-14 21:18     ` Jeff Dike [this message]
2005-09-16 19:20       ` Blaisorblade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050914211808.GA11567@ccure.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=blaisorblade@yahoo.it \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox