Re: [uml-devel] Re: TLS support - status - need for re-testing

[Blaisorblade <blaisorblade@yahoo.it>]

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

On Friday 24 March 2006 11:39, Antoine Martin wrote:
> On Thu, 2006-03-23 at 20:51 -0500, Jeff Dike wrote:
> > On Fri, Mar 24, 2006 at 12:44:05AM +0100, Blaisorblade wrote:
> > > Yes, that is true, but meanwhile give a testing to them, especially
> > > regressio test the new patches. I can't merge new patches in until I'm
> > > sure they don't cause regressions.
> >
> > OK, I give it a thumbs-up on a first boot - it's running my FC5
> > filesystem without any trouble.  I'll keep playing with it and let you
> > know of any trouble.
>
> I haven't been able to run FC4/FC5 x86 filesystems with any of the
> patches floating around. (on amd64 host)

I can inform you it's not FC4/FC5 but it's the amd64 host.

I missed this because I hadn't time for proper tests before, however:

add on top of 2.6.15-bb6 the attached patch. (It should more or less work 
against any other tls patchset, but I tested it like this).

Don't compile the resulting kernel for x86, and don't run the UML you get on 
x86 host!

As you can see (it touches include/asm-i386 only), this patch is an quick hack 
made for testing, but I know how to fix it, and I'm going to code it.

> > Attached is a tarball of the patches merged after the patches I have
> > planned for 2.6.17.  Nothing major, just some fuzz, some Makefile
> > rejections, and rejections from some whitespace cleanup in
> > kernel/skas/process_kern.c.

> I couldn't figure out in which order I need to apply these (no series
> file) and I've ran out of time.
Guess it's -bb6 series file (or I won't be able to apply them).
> Antoine

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

[-- Attachment #2: workaround-x86_64-host-problem --]
[-- Type: text/x-diff, Size: 521 bytes --]

Only for testing on x86_64 hosts.

Index: linux-2.6.15/include/asm-i386/segment.h
===================================================================
--- linux-2.6.15.orig/include/asm-i386/segment.h
+++ linux-2.6.15/include/asm-i386/segment.h
@@ -46,7 +46,7 @@
  *  31 - TSS for double fault handler
  */
 #define GDT_ENTRY_TLS_ENTRIES	3
-#define GDT_ENTRY_TLS_MIN	6
+#define GDT_ENTRY_TLS_MIN	12
 #define GDT_ENTRY_TLS_MAX 	(GDT_ENTRY_TLS_MIN + GDT_ENTRY_TLS_ENTRIES - 1)
 
 #define TLS_SIZE (GDT_ENTRY_TLS_ENTRIES * 8)