[uml-devel] uml_utilities-20060323 fails to build on alpha

[uml-devel] uml_utilities-20060323 fails to build on alpha

[Mattia Dongili]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hello,

I hear you say "who cares?" :)
Well, such failure uncovers a small bug on 64bit arches with __u64 not
defined as unsigned long long (oh, that "who cares" again :)).

cow.c: At top level:
cow.c:271: error: conflicting types for 'read_cow_header'
cow.h:25: error: previous declaration of 'read_cow_header' was here

the attached patch fixes it.

Thanks
-- 
mattia
:wq!

[-- Attachment #2: fix_moo_conflicting_types_for_read_cow_header.diff --]
[-- Type: text/plain, Size: 464 bytes --]

--- tools-20060323/moo/cow.c~clean	2006-04-09 19:10:15.324384228 +0200
+++ tools-20060323/moo/cow.c	2006-04-09 19:10:27.433140978 +0200
@@ -265,7 +265,7 @@
 
 int read_cow_header(int (*reader)(__u64, char *, int, void *), void *arg,
 		    __u32 *version_out, char **backing_file_out,
-		    time_t *mtime_out, unsigned long long *size_out,
+		    time_t *mtime_out, __u64 *size_out,
 		    int *sectorsize_out, __u32 *align_out,
 		    int *bitmap_offset_out)
 {

Re: [uml-devel] uml_utilities-20060323 fails to build on alpha

[Mattia Dongili]

On Sun, Apr 09, 2006 at 08:07:09PM +0200, Mattia Dongili wrote:
> Hello,
> 
> I hear you say "who cares?" :)
> Well, such failure uncovers a small bug on 64bit arches with __u64 not
> defined as unsigned long long (oh, that "who cares" again :)).
> 
> cow.c: At top level:
> cow.c:271: error: conflicting types for 'read_cow_header'
> cow.h:25: error: previous declaration of 'read_cow_header' was here

forgot to tell: full log of the failure is available here
http://buildd.debian.org/fetch.php?&pkg=uml-utilities&ver=20060323-1&arch=alpha&stamp=1144601041&file=log&as=raw

Thanks
-- 
mattia
:wq!


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] uml_utilities-20060323 fails to build on alpha

[Blaisorblade]

On Sunday 09 April 2006 20:07, Mattia Dongili wrote:
> Hello,
>
> I hear you say "who cares?" :)
> Well, such failure uncovers a small bug on 64bit arches with __u64 not
> defined as unsigned long long (oh, that "who cares" again :)).

No, you're right, good catch.

Systems using linux-libc-headers (i.e. RedHat and Fedora to my knowledge) 
exhibit this, and I've applied a similar patch to Uml itself for a Fedora 
user, but forgot it for uml_utilities. (I had "fixed" both instances of the 
COW code together).

Will apply the patch ASAP (at least next week) and release the resulting 
thing.

> cow.c: At top level:
> cow.c:271: error: conflicting types for 'read_cow_header'
> cow.h:25: error: previous declaration of 'read_cow_header' was here
>
> the attached patch fixes it.
>
> Thanks

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade


	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel